Closed
Bug 1272157
Opened 9 years ago
Closed 9 years ago
Expose HomePage settings to the MenuViewController via AppState
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jhugman, Assigned: jhugman)
References
Details
Attachments
(1 file)
Bug 1264638 fixes this in the general case; though this work proceeds this to allow Homepage to ship before wider architectural changes.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8752205 -
Flags: feedback?(etoop)
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → jhugman
Status: NEW → ASSIGNED
|
||
Updated•9 years ago
|
Attachment #8752205 -
Flags: feedback?(etoop) → feedback+
|
|
||
Comment 2•9 years ago
|
||
feedback in the PR
|
|
Assignee | |
Comment 3•9 years ago
|
||
Comment on attachment 8752205 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1816
Finished up patch for review.
Attachment #8752205 -
Flags: review?(etoop)
|
|
||
Comment 4•9 years ago
|
||
I am surprised that the homepage button is not available from the home panels menu. It makes sense to me that is where I would want to access my homepage from most frequently.
|
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8752205 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1816
A couple of comments in the PR and a question that might be for :tecgirl rather than you
Attachment #8752205 -
Flags: review?(etoop) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Merged.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•