1272179 - Filter field in object inspector in scratchpad is highlighted with blue while I edit code

Status: VERIFIED FIXED

(DevTools Graveyard :: Scratchpad, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160504043118
STR:
1. Open scratchpad
2. Select all text there, type "window" instead of selected text, press Ctrl+I
3. Click in filter field in object inspector at the right, then press Escape
4. Click on string "window" in codemirror instance, press Ctrl+I

AR:  Codemirror instance is focused, but filter field displays that shiny distracting blue highlight
ER:  Filter field shouldn't be all blue and shiny while it's not focused

Actually, I followed non-a11y way, so I expect no highlight at all. But that's left for the future...

This is regression from bug 1242851. Regression range:
> https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5a937f17f3369f64554d5552ecfeb22ef4757fcb&tochange=e60f6cb27fdd2f16d9c4aa9f1a79274af4f71184

Comment 1

[arni2033]

Attachment: screenshot 1 - Filter field in scratchpad is highlighted.png

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

The focus highlight exposed an issue with the search textbox never being unfocused.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: MozReview Request: Bug 1272179 - reset focus whenever the sidebar is hidden. r=bgrins

Review commit: https://reviewboard.mozilla.org/r/52217/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52217/

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=52fe0a6efe87

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8751789 [details]
MozReview Request: Bug 1272179 - reset focus whenever the sidebar is hidden. r=bgrins

https://reviewboard.mozilla.org/r/52217/#review49117

Thanks for the fix - I would have expected that the element becoming focused in the other frame would automatically blur the input field

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2e992920def8

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e992920def8

Comment 8

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 49.0a1 (2016-05-04) on windows 7, 6 Bit!

This bug's fix is verified on latest Developer Edition.

 Build ID   20160708004052

 User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

Comment 9

[Rezaul Huque Nayeem]

Reproduced this issue in firefox aurora 48.0a1 (2016-04-12) with ubuntu 16.04 (64 bit)

Verified as this issue fixed with latest firefox aurora 49.0a2 (Build ID: 20160723004004)
Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0

As it is also verified on windows (Comment 8), Marking it as verified!