1272189 - Remove null-check of mTaskQueue from FFmpegDataDecoder<LIBAV_VER>::Shutdown()

Status: RESOLVED INVALID

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Is it possible for |mTaskQueue| to be null?

Comment 1

[Jean-Yves Avenard [:jya]]

(In reply to JW Wang [:jwwang] from comment #0)
> Is it possible for |mTaskQueue| to be null?

It used to, but I believe I've removed all the cases when I fixed bug 1212323. There may still be some gtest that do though.

like this:
https://hg.mozilla.org/releases/mozilla-release/file/tip/dom/media/fmp4/MP4Decoder.cpp#l209

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Seeing FFmpegDataDecoder<LIBAV_VER>::ProcessShutdown() is safe to be called on all threads, can we just call ProcessShutdown() in Shutdown() without additional dispatch?

https://dxr.mozilla.org/mozilla-central/source/dom/media/platforms/PlatformDecoderModule.h#205
"Shutdown() must block until the decoder has completed shutdown."

So it might be better to call ProcessShutdown() directly without dispatching for API conformance.

Comment 3

[Jean-Yves Avenard [:jya]]

(In reply to JW Wang [:jwwang] from comment #2)
> Seeing FFmpegDataDecoder<LIBAV_VER>::ProcessShutdown() is safe to be called
> on all threads, can we just call ProcessShutdown() in Shutdown() without
> additional dispatch?

how so ?
the static monitor only ensure that not multiple decoder are shutting down ffmpeg at once (which isn't thread safe and cause various assert within ffmpeg).

I don't think it is safe to assume that the decoder is idle and finished prior shutdown being called.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

You are right. I will close this bug as invalid.