Closed Bug 1272225 Opened 4 years ago Closed 4 years ago

Remove use of FlushableTaskQueue::Flush() from AppleATDecoder::Flush()

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

Similar to bug 1271517.
Assignee: nobody → jwwang
Blocks: 1270039
Comment on attachment 8752009 [details]
MozReview Request: Bug 1272225. Part 1 - add assertions to make thread constraints clear. r=jya.

https://reviewboard.mozilla.org/r/52365/#review49389
Attachment #8752009 - Flags: review?(jyavenard) → review+
Attachment #8752010 - Flags: review?(jyavenard)
Comment on attachment 8752010 [details]
MozReview Request: Bug 1272225. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/52367/#review49391

::: dom/media/platforms/apple/AppleATDecoder.cpp:108
(Diff revision 1)
> +AppleATDecoder::Flush()
> +{
> +  MOZ_ASSERT(mCallback->OnReaderTaskQueue());
> +  LOG("Flushing AudioToolbox AAC decoder");
> +  mIsFlushing = true;
> +  nsresult rv = NS_OK;

theres nothing checking the return value of Flush(), you dont really need to worry about it.

could even make the API void while at it
Comment on attachment 8752010 [details]
MozReview Request: Bug 1272225. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/52367/#review49393
Attachment #8752010 - Flags: review+
Comment on attachment 8752011 [details]
MozReview Request: Bug 1272225. Part 3 - remove use of FlushableTaskQueue. r=jya.

https://reviewboard.mozilla.org/r/52369/#review49395
Attachment #8752011 - Flags: review?(jyavenard) → review+
https://reviewboard.mozilla.org/r/52367/#review49391

> theres nothing checking the return value of Flush(), you dont really need to worry about it.
> 
> could even make the API void while at it

Making change to the API is huge. I will let it just return NS_OK for now. When all this is done, we will come back at reviewing the interfade of MediaDataDecoder.
Thanks for the review!
You need to log in before you can comment on or make changes to this bug.