1272225 - Remove use of FlushableTaskQueue::Flush() from AppleATDecoder::Flush()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[JW Wang [:jwwang] [:jw_wang]]

Similar to bug 1271517.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1272225. Part 1 - add assertions to make thread constraints clear. r=jya.

Review commit: https://reviewboard.mozilla.org/r/52365/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52365/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1272225. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

Review commit: https://reviewboard.mozilla.org/r/52367/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52367/

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: MozReview Request: Bug 1272225. Part 3 - remove use of FlushableTaskQueue. r=jya.

Review commit: https://reviewboard.mozilla.org/r/52369/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52369/

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752009 [details]
MozReview Request: Bug 1272225. Part 1 - add assertions to make thread constraints clear. r=jya.

https://reviewboard.mozilla.org/r/52365/#review49389

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752010 [details]
MozReview Request: Bug 1272225. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/52367/#review49391

::: dom/media/platforms/apple/AppleATDecoder.cpp:108
(Diff revision 1)
> +AppleATDecoder::Flush()
> +{
> +  MOZ_ASSERT(mCallback->OnReaderTaskQueue());
> +  LOG("Flushing AudioToolbox AAC decoder");
> +  mIsFlushing = true;
> +  nsresult rv = NS_OK;

theres nothing checking the return value of Flush(), you dont really need to worry about it.

could even make the API void while at it

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752010 [details]
MozReview Request: Bug 1272225. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/52367/#review49393

Comment 7

[Jean-Yves Avenard [:jya]]

Comment on attachment 8752011 [details]
MozReview Request: Bug 1272225. Part 3 - remove use of FlushableTaskQueue. r=jya.

https://reviewboard.mozilla.org/r/52369/#review49395

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

https://reviewboard.mozilla.org/r/52367/#review49391

> theres nothing checking the return value of Flush(), you dont really need to worry about it.
> 
> could even make the API void while at it

Making change to the API is huge. I will let it just return NS_OK for now. When all this is done, we will come back at reviewing the interfade of MediaDataDecoder.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0779a62475e2
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8df198bb552
https://hg.mozilla.org/integration/mozilla-inbound/rev/f243def779e3

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0779a62475e2
https://hg.mozilla.org/mozilla-central/rev/d8df198bb552
https://hg.mozilla.org/mozilla-central/rev/f243def779e3