1272254 - Create a search field widget

Status: RESOLVED DUPLICATE of bug 908307

(DevTools :: Shared Components, enhancement)

Description

[Sebastian Zartner [:sebo]]

A general search field widget should be created, which can be reused by all the panels.

It's features would include:
- single content search
- multiple content search
- filtering instead of searching
- search/filter options
- search suggestions
- showing number matches
- indication for no matches
- focus shortcut
- clearing the field
- go to line feature

This was first proposed at https://groups.google.com/d/msg/mozilla.dev.developer-tools/hH_VBUx_rZA/TiD3gY0rIwAJ.

Sebastian

Comment 1

[Brian Grinstead [:bgrins]]

This might be a duplicate, I'm pretty sure Helen has done some design work around Search / Filter

Comment 2

[Brian Grinstead [:bgrins]]

(In reply to Sebastian Zartner [:sebo] from comment #0)
> A general search field widget should be created, which can be reused by all
> the panels.
> 
> It's features would include:
> - single content search
> - multiple content search

What is the difference between single content search and multiple content search?

> - filtering instead of searching
> - search/filter options

Search and filter are two distinct actions that I think should ultimately live in two different UI components.  For some tools one makes more sense than the other, and if they both have meaning then they would likely be two different inputs (how else would you toggle the 'mode' between them?)

> - search suggestions
> - showing number matches
> - indication for no matches
> - focus shortcut
> - clearing the field
> - go to line feature

"Go to line" only makes sense for tools who are primarily showing a source.  Are you thinking this component would only be used for those kinds of tools?  Also, how would you trigger 'go to line' from the search box?

Comment 3

[Brian Grinstead [:bgrins]]

This might be a dupe of Bug 1265759

Comment 4

[Sebastian Zartner [:sebo]]

(In reply to Brian Grinstead [:bgrins] from comment #2)
> (In reply to Sebastian Zartner [:sebo] from comment #0)
> > A general search field widget should be created, which can be reused by all
> > the panels.
> > 
> > It's features would include:
> > - single content search
> > - multiple content search
> 
> What is the difference between single content search and multiple content
> search?

The multiple content search means to search within several files. In the Debugger's search field this is called 'Search in all files'.

> > - filtering instead of searching
> > - search/filter options
> 
> Search and filter are two distinct actions that I think should ultimately
> live in two different UI components.

Probably, yes, I was unsure about that.

> > - go to line feature
> 
> "Go to line" only makes sense for tools who are primarily showing a source. 
> Are you thinking this component would only be used for those kinds of tools?

Yes, might be a specialized component.

> Also, how would you trigger 'go to line' from the search box?

Like it's done now within the Debugger's search field, writing a colon and then the line number.

Sebastian

Comment 5

[Sebastian Zartner [:sebo]]

(In reply to Brian Grinstead [:bgrins] from comment #3)
> This might be a dupe of Bug 1265759

Could be, though bug 1265759 comment 2 sounds like this only targets the Inspector panel's search fields.
Feel free to mark it this one as a duplicate if bug 1265759 should cover all fields.

Sebastian

Comment 6

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to Brian Grinstead [:bgrins] from comment #3)
> This might be a dupe of Bug 1265759

We're drowning in search box/filter box bugs, so Nicolas and I have made bug 908307 a metabug for all of these. I would consider this bug a dupe of that one.

I'll be attaching a better spec sheet on that bug.

Sebastian, would you be willing to move relevant comments over to that bug and close this one out?

Comment 7

[Sebastian Zartner [:sebo]]

(In reply to Helen V. Holmes (:helenvholmes) (:✨)(pls ni?) from comment #6)
> Sebastian, would you be willing to move relevant comments over to that bug
> and close this one out?

Done in bug 908307 comment 8.

Sebastian