1272275 - webrtc: add NetBSD video support

Status: RESOLVED DUPLICATE of bug 826985

(Core :: WebRTC: Audio/Video, defect, P4)

Description

[Thomas Klausner]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160502172042

Steps to reproduce:

NetBSD has support for Linux' v4l2 API. pkgsrc carries a patch that adds some compatibility/options for it, I've applied it to trunk.

Comment 1

[Thomas Klausner]

Attachment: NetBSD-webrtc.diff

Patch from pkgsrc applied to trunk.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8751683 [details] [diff] [review]
NetBSD-webrtc.diff

Review of attachment 8751683 [details] [diff] [review]:
-----------------------------------------------------------------

See bug 826985, which includes most of this.  Likely this should be dupped to that bug, and if there's anything here missing there, added to that one.

::: old-configure.in
@@ +3638,5 @@
>      MOZ_RAW=1
>      MOZ_VPX_ERROR_CONCEALMENT=1
>  
> +    dnl with libv4l2 we can support more cameras
> +    PKG_CHECK_MODULES(MOZ_LIBV4L2, libv4l2)

Almost all library dependencies have --enable/disable controls in old-configure.in

Also: this tells you if the current system has the library, but that could be bad for packaging builds (admittedly, something the BSDs generally avoid).  With --enable/disable, one can control if the dependency is baked in or not, but as in bug 826985, a dynamic load/dlsym gets you a much better packaged experience (and maybe even for local builds if something changes).

Comment 3

[Thomas Klausner]

I compared my diff against the latest one in Bug 826985, and that one is a strict superset (except for old-configure.in which is handled better there). I'll close this bug now.