Closed Bug 1272359 Opened 6 years ago Closed 6 years ago

Report support for AVX and AVX2 in telemetry

Categories

(Toolkit :: Telemetry, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jrmuizel, Assigned: jrmuizel)

References

Details

(Whiteboard: [measurement:client])

Attachments

(1 file)

No description provided.
Depends on: 1270591
Whiteboard: [measurement:client]
Attachment #8753561 - Flags: review?(gfritzsche)
Assignee: nobody → jmuizelaar
Comment on attachment 8753561 [details] [diff] [review]
Report AVX and AVX2

Review of attachment 8753561 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me, flagging bsmedberg for data collection review:
https://wiki.mozilla.org/Firefox/Data_Collection

::: toolkit/components/telemetry/TelemetryEnvironment.jsm
@@ -1201,5 @@
>      };
>  
>      const CPU_EXTENSIONS = ["hasMMX", "hasSSE", "hasSSE2", "hasSSE3", "hasSSSE3",
> -                            "hasSSE4A", "hasSSE4_1", "hasSSE4_2", "hasEDSP", "hasARMv6",
> -                            "hasARMv7", "hasNEON"];

Please also update the documentation in toolkit/components/telemetry/docs/environment.rst
You can view it using |mach doc| and is used to generate this:
https://gecko.readthedocs.org/en/latest/toolkit/components/telemetry/telemetry/environment.html
Attachment #8753561 - Flags: review?(gfritzsche)
Attachment #8753561 - Flags: review+
Attachment #8753561 - Flags: feedback?(benjamin)
Comment on attachment 8753561 [details] [diff] [review]
Report AVX and AVX2

With the docs updated, data-review=me
Attachment #8753561 - Flags: feedback?(benjamin) → feedback+
https://hg.mozilla.org/mozilla-central/rev/2fc681d07cc0
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.