1272364 - [rep tests] Ensure that ARIA presentation role is handled correctly in reps

Status: RESOLVED FIXED

(DevTools :: Shared Components, defect, P1)

Description

[Lin Clark [:linclark]]

Currently the role attribute is set to presentation for most DOM nodes output by reps. This includes values that are output by reps. For example, the value of the strProp of the following object:

> {strProp: "test string"}

would output like this

> <span class="objectBox objectBox-string" role="presentation">"test string"</span>

Unless I misunderstand, this means that non-sighted users wouldn't hear the value of the property. This doesn't sound like the desired user experience.

Honza, can you confirm how this should work and whether it is currently working as expected? 

If it is not, I suggest that we remove the role all together until we know what we want to apply it to.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Agree, this isn't complete and we should do it right.
For now we can remove it.

Honza

Comment 2

[Lin Clark [:linclark]]

Attachment: Bug1272364.patch

Here's a patch, but we should probably wait to commit it until all of the affected reps have tests.

Comment 3

[[e-mail]]

lin, does this issue able to be fixed now?

Comment 4

[Lin Clark [:linclark]]

Yes, we just need to remove all ARIA roles for the time being.

Comment 5

[[e-mail]]

Attachment: Bug 1272364 - [rep]Remove role presentation to let vision inpaired hear it;

Review commit: https://reviewboard.mozilla.org/r/75252/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75252/

Comment 6

[Lin Clark [:linclark]]

Comment on attachment 8786246 [details]
Bug 1272364 - [rep]Remove role presentation to let vision inpaired hear it;

https://reviewboard.mozilla.org/r/75252/#review73134

Comment 7

[Lin Clark [:linclark]]

Comment on attachment 8786246 [details]
Bug 1272364 - [rep]Remove role presentation to let vision inpaired hear it;

https://reviewboard.mozilla.org/r/75252/#review73136

This looks good to me, but we should make sure it's green on try before committing.

Comment 8

[[e-mail]]

treeherder green, thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/135621463dac
[rep] Remove role presentation to let vision inpaired hear it. r=linclark

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/135621463dac

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Too late for 49. Is this something that might be good to uplift for 50? If not then it's fine to let the fix ride the trains with 51.

Comment 12

[[e-mail]]

Lin do you think its ok to let the fix ride the trains, or like to uplift it for 50?

Comment 13

[Lin Clark [:linclark]]

It's fine to ride the trains

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Based on comment 13, this is now a wontfix for Fx50.