Closed Bug 1272391 Opened 4 years ago Closed 4 years ago

SimpleHelperUI button should post "action" not "cancel" telemetry event

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 49
Tracking Status
firefox48 --- fixed
firefox49 --- fixed

People

(Reporter: ahunt, Assigned: ahunt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We're sending CANCEL instead of ACTION when the button in the SimpleHelperUI is selected. (This is used for the readerview-bookmark-prompt, and will be used for further helper UIs soon.)

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/promotion/SimpleHelperUI.java#119
Assignee: nobody → ahunt
I didn't pay attention while copying telemetry events. We send cancel when dismissing
the prompt, action when the user selects the suggested prompt action.

Review commit: https://reviewboard.mozilla.org/r/52241/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52241/
Attachment #8751836 - Flags: review?(s.kaspari)
Blocks: migrate-RL
Attachment #8751836 - Flags: review?(s.kaspari) → review+
Comment on attachment 8751836 [details]
MozReview Request: Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r?sebastian

https://reviewboard.mozilla.org/r/52241/#review49455
https://hg.mozilla.org/integration/fx-team/rev/7084bd828e4c688daf6078a710d2f267bb52591a
Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r=sebastian
Comment on attachment 8751836 [details]
MozReview Request: Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r?sebastian

Approval Request Comment
[Feature/regressing bug #]: Bug 1246238
[User impact if declined]: no user impact. UI telemetry contains incorrect action (cancel instead of action). This should be fixed in the next nightly, I'd prefer to update aurora (where this landed) for consistency when analysing UI telemetry.
[Describe test coverage new/current, TreeHerder]: none (except manual local testing).
[Risks and why]: Very low risk: different constant passed into call that sends UI telemetry from the reader view bookmark prompt.
[String/UUID change made/needed]: none.
Attachment #8751836 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/7084bd828e4c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8751836 [details]
MozReview Request: Bug 1272391 - Send Action instead of Cancel from SimpleHelperUI button r?sebastian

Improve the telemetry data, taking it.
Attachment #8751836 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.