1272398 - use UniquePtr instead of nsAutoPtr for {Layer,LayerData}::RemoveUserData return type

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: use UniquePtr instead of nsAutoPtr for {Layer,LayerData}::RemoveUserData return type

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d201ae294f8

Comment 3

[Daniel Holbert [:dholbert]]

I backed this out...
  https://hg.mozilla.org/integration/mozilla-inbound/rev/c403ac05b8f4
...on a hunch that it's involved with a mysterious PGO perma-red bug 1274450 (a crash whose stack is in layers code, which also seems to have been triggered yesterday for a short while by a different layers-code changeset which was subsequently backed out for unrelated reasons).

See bug 1274450 comment 5 for more details.  (The "blame" push range for today's instance of this PGO crash is pretty small (linked in bug 1274450 comment 0), and this seems to be the only layers-related change in that pushlog.  So I'm guessing this may be the proximal "guilty" cset. Though the real bug is probably some other latent issue, and hopefully we'll have that sorted out soon in bug 1274450.)

It's entirely possible that my hunch is wrong; if so, please accept my apologies and re-land away, once the tree's open again.

Comment 4

[Daniel Holbert [:dholbert]]

froydnj, you should be OK to re-land, now that dbaron's fixed the root issue in bug 1274450 (by disabling PGO for some code that was being miscompiled).

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bece6d2a5793

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bece6d2a5793