Closed
Bug 1272411
Opened 8 years ago
Closed 7 years ago
[Context Menu] Provide a 1.25x faster video speed option in the video controls. Also add UI to loop playback of media files
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(seamonkey2.50 fixed)
RESOLVED
FIXED
seamonkey2.50
Tracking | Status | |
---|---|---|
seamonkey2.50 | --- | fixed |
People
(Reporter: philip.chee, Assigned: sherman.s.wang, Mentored)
References
Details
(Whiteboard: [good first bug][gfb][lang=js,xul,dtd])
User Story
Bug 1126282 - Provide a 1.25x faster video speed option in the video controls Bug 862399 - Add UI to loop playback of audio files
Attachments
(1 file, 1 obsolete file)
6.84 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
(From Bug 1126282 comment #0) > The current video speed options don't work very well for spoken audio. 1.5x > is too fast. I'd like a video option in between. Currently, I end up using > the devtools to set this. > YouTube offers 1.25x for their HTML5 player. Would 1.25x work for you? It > would be nice to be consistent with them.
Reporter | ||
Updated•8 years ago
|
User Story: (updated)
See Also: → 862399
Summary: [Context Menu] Provide a 1.25x faster video speed option in the video controls → [Context Menu] Provide a 1.25x faster video speed option in the video controls. Also add UI to loop playback of media files
Comment 1•8 years ago
|
||
Hi, I would be interested in doing this for my first bug. Would it be possible? Thanks.
Reporter | ||
Comment 2•8 years ago
|
||
(In reply to Horatiu Lazu from comment #1) > Hi, I would be interested in doing this for my first bug. Would it be > possible? Thanks. Yes certainly. We won't change the status to ASSIGNED until we see a patch from you. So please proceed. If you need any assistance you can find us on IRC irc://moznet/seamonkey
Comment 4•8 years ago
|
||
I'm no longer working on it, I'm working on another bug right now
Assignee | ||
Comment 5•7 years ago
|
||
If nobody else is currently working this, I'd like to tackle it as my first bug.
Assignee | ||
Comment 6•7 years ago
|
||
port of Firefox implementation for 1.25x video speed option and video looping UI
Assignee | ||
Comment 7•7 years ago
|
||
Seeing as Richa hasn't been active since mid-October, I've uploaded a patch that ports the implementation from Firefox including their updated verbiage for video speeds. A few other minor fixes from the Firefox block of code came along for the ride as well; please advise if they should be removed.
Comment 8•7 years ago
|
||
Comment on attachment 8822113 [details] [diff] [review] 1272411.patch Looks good to me. Will check it out later.
Attachment #8822113 -
Flags: review?(philip.chee)
Attachment #8822113 -
Flags: review?(iann_bugzilla)
Attachment #8822113 -
Flags: feedback?(frgrahl)
Comment 9•7 years ago
|
||
Comment on attachment 8822113 [details] [diff] [review] 1272411.patch 1.25 and loop work fine for me from the context menu.
Attachment #8822113 -
Flags: feedback?(frgrahl) → feedback+
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → sherman.s.wang
Status: NEW → ASSIGNED
Reporter | ||
Comment 10•7 years ago
|
||
Comment on attachment 8822113 [details] [diff] [review] 1272411.patch Nice patch! > - this.showItem("context-video-fullscreen", this.onVideo); > + this.showItem("context-video-fullscreen", this.onVideo && > + this.target.ownerDocument.fullscreenElement == null); This can be written as: this.showItem("context-video-fullscreen", this.onVideo && !this.target.ownerDocument.fullscreenElement); > + this.setItemAttr("context-media-playbackrate-050", "disabled", hasError); > + this.setItemAttr("context-media-playbackrate-100", "disabled", hasError); > + this.setItemAttr("context-media-playbackrate-125", "disabled", hasError); > + this.setItemAttr("context-media-playbackrate-150", "disabled", hasError); > + this.setItemAttr("context-media-playbackrate-200", "disabled", hasError); These are not needed as the whole popup is disabled. > -<!ENTITY mediaPlaybackRate.label "Playback Speed"> > -<!ENTITY mediaPlaybackRate.accesskey "b"> > -<!ENTITY mediaPlaybackRate050.label "Slow Motion (½×)"> > -<!ENTITY mediaPlaybackRate100.label "Normal Speed"> > -<!ENTITY mediaPlaybackRate150.label "High Speed (1½×)"> > -<!ENTITY mediaPlaybackRate150.accesskey "H"> > -<!ENTITY mediaPlaybackRate200.label "Double Speed"> > -<!ENTITY mediaPlaybackRate200.accesskey "D"> Don't change these please. > +<!ENTITY mediaPlaybackRate125.label "Fast (1.25×)"> > +<!ENTITY mediaPlaybackRate125.accesskey "F"> Please use UTF 8 character for ¼ e.g. "Fast Speed (1¼×)" > +<!ENTITY mediaLoop.label "Loop"> > +<!ENTITY mediaLoop.accesskey "L"> L is taken by "Copy Video _L_ocation". I think "o" is still available.
Attachment #8822113 -
Flags: review?(philip.chee)
Attachment #8822113 -
Flags: review?(iann_bugzilla)
Assignee | ||
Comment 11•7 years ago
|
||
Updated patch per feedback from Comment #10
Attachment #8822113 -
Attachment is obsolete: true
Comment 12•7 years ago
|
||
Sherman, you need to set r? or it will get lost in time. Philip and IanN are the reviewers for SeaMonkey. I can do it for you like the last time but then I get the direct notifications too.
Assignee | ||
Updated•7 years ago
|
Attachment #8823078 -
Flags: review?(philip.chee)
Assignee | ||
Updated•7 years ago
|
Attachment #8823078 -
Flags: review?(iann_bugzilla)
Assignee | ||
Comment 13•7 years ago
|
||
(In reply to Frank-Rainer Grahl from comment #12) > Sherman, > > you need to set r? or it will get lost in time. Philip and IanN are the > reviewers for SeaMonkey. I can do it for you like the last time but then I > get the direct notifications too. Thanks for catching that. I think I have the r? flag set correctly now.
Comment 14•7 years ago
|
||
Comment on attachment 8823078 [details] [diff] [review] 1272411-2.patch r/a=me
Attachment #8823078 -
Flags: review?(iann_bugzilla) → review+
Comment 15•7 years ago
|
||
Sherman, I pushed the bug for you. The next time please add a commit message to it. https://hg.mozilla.org/comm-central/rev/52def7491f3399fe04989958a4508989daee4571
status-seamonkey2.50:
--- → fixed
Target Milestone: --- → seamonkey2.50
Updated•7 years ago
|
Attachment #8823078 -
Flags: review?(philip.chee)
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•