Closed Bug 1272501 Opened 6 years ago Closed 5 years ago

Add telemetry about the usage of blink filesystem API, webkitdirectory API and directory upload API

Categories

(Core :: DOM: Core & HTML, defect)

36 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: smaug, Assigned: baku)

References

Details

(Whiteboard: btpp-fixlater)

Attachments

(2 files)

Once we start to ship these APIs, better to know which ones are being used.
What bugs should this depend upon?
Flags: needinfo?(bugs)
Whiteboard: btpp-fixlater
Depends on: 1265767
Flags: needinfo?(bugs)
Assignee: nobody → amarchesini
Attached patch telemtry.patchSplinter Review
Attachment #8765394 - Flags: review?(bugs)
Comment on attachment 8765394 [details] [diff] [review]
telemtry.patch

So this is just one part, only for .WebkitEntries
Attachment #8765394 - Flags: review?(bugs) → review+
The rest is for DnD, right? But that part is not implemented yet.
The patch is for DnD. WebKitEntries is part of the DnD API.
webkitdirectory is not. or something like that.
Right. With DnD I meant DataTransfer Event but that part is not implemented. I'll file a follow up to add telemetry there too.

I didn't want to add telemetry for webkitdirectory attribute. In case we want, we should not have the same telemetry ID.
Are you OK to land and resolve this bug with only this patch?

If we care about webkitdirectory attribute, I can file a follow up.
Why wouldn't we have telemetry for webkitdirectory but would have for .WebkitEntries?
I would add separate probe for them both.
Attached patch telemetry2.patchSplinter Review
Here telemetry for webkitdirectory attribute
Attachment #8765965 - Flags: review?(bugs)
Attachment #8765965 - Flags: review?(bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b65ae48153f6
Add Telemetry to the Blink/Webkit FileSystem API - part 1, r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/f09c9e7c842d
Add Telemetry to the Blink/Webkit FileSystem API - part 2, r=smaug
https://hg.mozilla.org/mozilla-central/rev/b65ae48153f6
https://hg.mozilla.org/mozilla-central/rev/f09c9e7c842d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.