Closed
Bug 1272506
Opened 8 years ago
Closed 8 years ago
Change GeckoApp.ONE_DAY_MS to be initialized with the TimeUnit class
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox49 fixed)
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: mcomella, Assigned: cesar.valiente, Mentored)
Details
(Whiteboard: [lang=java][good first bug])
Attachments
(1 file)
To start, set up a build environment - you can see the instructions here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build Then, you'll need to create a patch to upload - see https://wiki.mozilla.org/Mobile/Fennec/Android/Suggested_workflow#Creating_commits_and_submitting_patches You can find more miscellaneous information at: https://wiki.mozilla.org/Mobile/Fennec/Android To fix this bug, change GeckoApp.ONE_DAY_MS [1] to be initialized with the TimeUnit class [2]. If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC Thanks and happy coding! ^_^ [1]: https://dxr.mozilla.org/mozilla-central/rev/3461f3cae78495f100a0f7d3d2e0b89292d3ec02/mobile/android/base/java/org/mozilla/gecko/GeckoApp.java#143 [2]: https://developer.android.com/reference/java/util/concurrent/TimeUnit.html
Assignee | ||
Comment 1•8 years ago
|
||
Hi Michael, I will take this one, so I can send my first patch (I'm working in another bug that is more complex, but for a first patch this one sounds easier). Thanks for the info.
Assignee | ||
Comment 2•8 years ago
|
||
First patch submitted. Not sure if the way I used to create the patch was completely correct. First time using Mercurial and this patch way to submit proposed fixes. Please, let me know with anything so I can learn more. Thanks!
Attachment #8752460 -
Flags: review+
Attachment #8752460 -
Flags: feedback+
Reporter | ||
Updated•8 years ago
|
Assignee: nobody → cesar.valiente
Reporter | ||
Comment 3•8 years ago
|
||
Comment on attachment 8752460 [details] [diff] [review] Fixing the hardcoded day into milliseconds used in GeckoApp class, for the more appropriate usage of TimeUnit class Review of attachment 8752460 [details] [diff] [review]: ----------------------------------------------------------------- This looks good! I made a push to our try test servers (above). Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results. By the way, sorry for the delay. When requesting a review, you should set the flag to `r?` and select one of the suggested users (or provide their email address in the field). r+ are used to mark a successfully reviewed patch and unfortunately no one gets notified when those flags are set (unlike r?). [1]: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_checked_into_the_tree
Attachment #8752460 -
Flags: review+
Attachment #8752460 -
Flags: feedback+
Reporter | ||
Comment 4•8 years ago
|
||
(In reply to Michael Comella (:mcomella) from comment #3) > I made a push to our try test servers (above). Oh nevermind, the tree is closed. I'll push to try once it's open.
Flags: needinfo?(michael.l.comella)
Reporter | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9c161255b564
Reporter | ||
Updated•8 years ago
|
Flags: needinfo?(michael.l.comella)
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•8 years ago
|
||
Hi Michael, thanks for your review and the info/feedback provided, very happy to hear the patch was correct :-) I've already added the flag "checkin-needed". Let me know about anything else I have to do. Thanks again.
Comment 8•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a341a931d016
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•