Closed Bug 1272506 Opened 6 years ago Closed 6 years ago

Change GeckoApp.ONE_DAY_MS to be initialized with the TimeUnit class


(Firefox for Android Graveyard :: General, defect)

Not set


(firefox49 fixed)

Firefox 49
Tracking Status
firefox49 --- fixed


(Reporter: mcomella, Assigned: cesar.valiente, Mentored)


(Whiteboard: [lang=java][good first bug])


(1 file)

To start, set up a build environment - you can see the instructions here:

Then, you'll need to create a patch to upload - see

You can find more miscellaneous information at:

To fix this bug, change GeckoApp.ONE_DAY_MS [1] to be initialized with the TimeUnit class [2].

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see

Thanks and happy coding! ^_^

Hi Michael,

I will take this one, so I can send my first patch (I'm working in another bug that is more complex, but for a first patch this one sounds easier).

Thanks for the info.
First patch submitted. 
Not sure if the way I used to create the patch was completely correct. 
First time using Mercurial and this patch way to submit proposed fixes. 

Please, let me know with anything so I can learn more.

Attachment #8752460 - Flags: review+
Attachment #8752460 - Flags: feedback+
Assignee: nobody → cesar.valiente
Comment on attachment 8752460 [details] [diff] [review]
Fixing the hardcoded day into milliseconds used in GeckoApp class, for the more appropriate usage of TimeUnit class

Review of attachment 8752460 [details] [diff] [review]:

This looks good!

I made a push to our try test servers (above).

Once the push goes green, you can add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches added via checkin-needed keyword need an associated green try run. Let me know if you need help reading the results.

By the way, sorry for the delay. When requesting a review, you should set the flag to `r?` and select one of the suggested users (or provide their email address in the field). r+ are used to mark a successfully reviewed patch and unfortunately no one gets notified when those flags are set (unlike r?).

Attachment #8752460 - Flags: review+
Attachment #8752460 - Flags: feedback+
(In reply to Michael Comella (:mcomella) from comment #3)
> I made a push to our try test servers (above).

Oh nevermind, the tree is closed. I'll push to try once it's open.
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(michael.l.comella)
Keywords: checkin-needed
Hi Michael,

thanks for your review and the info/feedback provided, very happy to hear the patch was correct :-)

I've already added the flag "checkin-needed".

Let me know about anything else I have to do.

Thanks again.
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.