Closed
Bug 1272546
Opened 8 years ago
Closed 8 years ago
unauthenticated users cannot expand the cc list
Categories
(bugzilla.mozilla.org :: User Interface, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: glob, Unassigned)
References
Details
Attachments
(1 file, 1 obsolete file)
3.20 KB,
patch
|
dylan
:
review+
|
Details | Diff | Splinter Review |
if you're not logged in you'll get a token error when trying to expand the cc list. i propose removing the ability for unauthenticated requests to do that - they'd still be able to tell how many people are cc'd, but they will have to create an account in order to get the actual list.
Updated•8 years ago
|
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Comment 1•8 years ago
|
||
Attachment #8757025 -
Flags: review?(dylan)
Comment on attachment 8757025 [details] [diff] [review] 1272546_1.patch Review of attachment 8757025 [details] [diff] [review]: ----------------------------------------------------------------- ::: extensions/BugModal/web/bug_modal.js @@ +232,5 @@ > + .hover(function() { > + $(this).css({'text-decoration': 'underline'}); > + }, function() { > + $(this).css({'text-decoration': 'none'}); > + }); it would be better to use two different css classes than move the styling out of the stylesheet into javascript.
Comment 3•8 years ago
|
||
Attachment #8757025 -
Attachment is obsolete: true
Attachment #8757025 -
Flags: review?(dylan)
Attachment #8757351 -
Flags: review?(dylan)
Comment 4•8 years ago
|
||
Comment on attachment 8757351 [details] [diff] [review] 1272546_2.patch Review of attachment 8757351 [details] [diff] [review]: ----------------------------------------------------------------- r=dylan
Attachment #8757351 -
Flags: review?(dylan) → review+
Comment 5•8 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git e31c0e9..a092e46 master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: User Interface: Modal → User Interface
Updated•5 years ago
|
Assignee: dkl → nobody
You need to log in
before you can comment on or make changes to this bug.
Description
•