Do not show up focus ring in Reader Controls

RESOLVED FIXED

Status

()

Toolkit
Reader Mode
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: magicp, Unassigned)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(e10s+, firefox48 unaffected, firefox49 affected)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Created attachment 8752024 [details]
reader-controls-focus-ring.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160502172042

Steps to reproduce:

1. Start Nightly
2. Go to "https://developer.mozilla.org/en-US/Firefox"
3. Open reader view
4. Open font control
5. Click any buttons 


Actual results:

Focus ring shows up.

Regression range is below. but got exception in mozregression-gui
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=7189e5f1105bb41782187b9876bbcc625f4208d8&tochange=e4e6e8589b76d09f1fa43186cbca61bdac430254


Expected results:

Do not show up focus ring in Reader Controls
(Reporter)

Updated

2 years ago
status-firefox48: --- → unaffected
status-firefox49: --- → affected
Likely cause of regression: bug 1263330
Blocks: 1263330
Flags: needinfo?(enndeakin)

Comment 2

2 years ago
Is this an e10s window? From a brief test, the panels appear to be some kind of fake (and buggy) panel inside the window. This would to me indicate that they are part of the content.

Focus ring issues with content in e10s are bug 1174798.
Depends on: 1174798
Flags: needinfo?(enndeakin)
(Reporter)

Comment 3

2 years ago
(In reply to Neil Deakin from comment #2)
> Is this an e10s window? From a brief test, the panels appear to be some kind
> of fake (and buggy) panel inside the window. This would to me indicate that
> they are part of the content.
> 
> Focus ring issues with content in e10s are bug 1174798.

Yes, this is an e10s window. It was fixed in Bug 1253610, but it has occurred again.
tracking-e10s: --- → ?

Comment 4

2 years ago
I confirmed that the patch in 1174798 fixes this.

Updated

2 years ago
tracking-e10s: ? → +
Priority: -- → P3

Updated

2 years ago
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.