1272550 - Do not show up focus ring in Reader Controls

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect, P3)

Description

[magicp]

Attachment: reader-controls-focus-ring.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160502172042

Steps to reproduce:

1. Start Nightly
2. Go to "https://developer.mozilla.org/en-US/Firefox"
3. Open reader view
4. Open font control
5. Click any buttons 


Actual results:

Focus ring shows up.

Regression range is below. but got exception in mozregression-gui
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=7189e5f1105bb41782187b9876bbcc625f4208d8&tochange=e4e6e8589b76d09f1fa43186cbca61bdac430254


Expected results:

Do not show up focus ring in Reader Controls

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Likely cause of regression: bug 1263330

Comment 2

[Neil Deakin]

Is this an e10s window? From a brief test, the panels appear to be some kind of fake (and buggy) panel inside the window. This would to me indicate that they are part of the content.

Focus ring issues with content in e10s are bug 1174798.

Comment 3

[magicp]

(In reply to Neil Deakin from comment #2)
> Is this an e10s window? From a brief test, the panels appear to be some kind
> of fake (and buggy) panel inside the window. This would to me indicate that
> they are part of the content.
> 
> Focus ring issues with content in e10s are bug 1174798.

Yes, this is an e10s window. It was fixed in Bug 1253610, but it has occurred again.

Comment 4

[Neil Deakin]

I confirmed that the patch in 1174798 fixes this.