Closed
Bug 1272557
Opened 8 years ago
Closed 8 years ago
Autophone - Throbber stop regression 2016-03-09 in S1S2 on fx-team
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox47 unaffected, firefox48 fixed, firefox49 fixed, fennec48+)
RESOLVED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox47 | --- | unaffected |
firefox48 | --- | fixed |
firefox49 | --- | fixed |
fennec | 48+ | --- |
People
(Reporter: bc, Assigned: jchen)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file)
2.56 KB,
patch
|
snorp
:
review+
gchang
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Autophone shows a regression from 2.5% to 6.9% in throbberstop on 2016-03-09 http://phonedash.mozilla.org/#/2016-03-09/2016-03-10/binning=repo-phonetype-phoneid-test_name-cached_label-metric&rejected=norejected&errorbars=errorbars&errorbartype=standarderror&valuetype=median&local-blank=on&throbberstop=on&second=on&fx-team=on&nexus-4-6=on&nexus-5-4=on&nexus-9-1=on http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=b2b0a09c6e1af30437efc99c295d51598d86293d&tochange=82efa3bc873182d3ab5d450a1a784db7a3d1aba6 It appears in all tests and for first and second visits though local-blank has a clearer signal. It also appears later on mozilla-central and mozilla-inbound as the merges occur. Looks like Bug 1252666 - Flip dom.push.enabled to true in Firefox for Android
Reporter | ||
Updated•8 years ago
|
Summary: Autophone - 2016-03-09 Throbber stop regression in S1S2 on fx-team → Autophone - Throbber stop regression 2016-03-09 in S1S2 on fx-team
Comment 1•8 years ago
|
||
It looks like enabling push notifications regressed page load time. Jim, can you look into this? (Edwin, I wanted to make sure this is on the push team's radar.)
Flags: needinfo?(nchen)
Flags: needinfo?(edwong)
Assignee: nobody → nchen
tracking-fennec: ? → 48+
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(nchen)
Assignee | ||
Comment 2•8 years ago
|
||
Delay initialization of PushService and DLC in GeckoApplication to after the Gecko:Ready message. That way, hopefully they give up some CPU time to other initialization tasks.
Attachment #8756954 -
Flags: review?(snorp)
Attachment #8756954 -
Flags: review?(snorp) → review+
Comment 4•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e97d36a133b7
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox49:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8756954 [details] [diff] [review] Delay initializing PushService and DLC (v1) Approval Request Comment [Feature/regressing bug #]: Push [User impact if declined]: Slower startup time due to push being enabled [Describe test coverage new/current, TreeHerder]: Locally, m-c [Risks and why]: There is one known regression (bug 1280446), which will be uplifted; otherwise the risk is small because the patch simply delays push initialization on startup [String/UUID change made/needed]: None
Attachment #8756954 -
Flags: approval-mozilla-beta?
Updated•8 years ago
|
Comment 6•8 years ago
|
||
Comment on attachment 8756954 [details] [diff] [review] Delay initializing PushService and DLC (v1) Review of attachment 8756954 [details] [diff] [review]: ----------------------------------------------------------------- This patch fixes slower startup time. Take it in 48 beta 7. The fix should be in fennec 48 beta 8.
Attachment #8756954 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/5c39f5f66157
Updated•8 years ago
|
Flags: needinfo?(edwong)
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•