1272595 - Webextension is not downloaded and a corrupt message is displayed

Status: RESOLVED INVALID

(WebExtensions :: Untriaged, defect)

Description

[CosminB]

[Affected versions]:
Firefox 49.0a1 (2016-05-12)
Firefox 48.0a2 (2016-05-12)
Firefox 47.0b5 (20160512003946)
Firefox 46.0.1 (20160502172042)

[Affected platforms]:
Windows 7 64-bit
Ubuntu 14.04 64-bit
Mac OS X 10.9.5

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create the xpinstall.signatures.dev-root pref in about:config and set it to true.
3.Install the following webextension: https://addons.allizom.org/en-US/firefox/addon/dtmobile-trade-forex/ 


[Expected results]:
The webextension is installed.

[Actual results]:
- The webextension could not be installed because it appears to be corrupted.
- The following error is thrown in Browser Console:
1463128782182	[e-mail]	ERROR	Loading extension '[e-mail]': Loading locale file _locales/fr/messages.json: SyntaxError: JSON.parse: bad control character in string literal at line 6 column 151 of the JSON data


[Regression range]:
Last good revision: df66cac11155fda2f1d336d71dfc529b22636b81
First bad revision: d34bfda459c96a520d1a3a168e696d990599ea2e
Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=df66cac11155fda2f1d336d71dfc529b22636b81&tochange=d34bfda459c96a520d1a3a168e696d990599ea2e

I suspect that this issue was regressed by Bug 1192433

[Additional notes]:
I’ve also encountered this issue while installing the following webextension: https://addons.allizom.org/en-US/firefox/addon/mightytextsms/

Comment 1

[Kris Maglione [:kmag]]

Well, that JSON file is definitely invalid. It has a newline in the middle of a string literal. I'm not sure why it says "bad control character", though.

Comment 2

[Kris Maglione [:kmag]]

Closing this as invalid, since the extension is indeed invalid. Please reopen if there are other issues I'm not seeing.

Comment 3

[CosminB]

The second webextension has a different error message :

1463384996882	[e-mail]	ERROR	Loading extension '[e-mail]': Loading locale file _locales/svn/messages.json: [Exception... "Failed to open input source 'jar:file:///C:/Users/COSMIN~1.BAD/AppData/Local/Temp/tmp-yi5.xpi!/_locales/svn/messages.json'"  nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame :: resource://gre/modules/Extension.jsm :: readJSON/< :: line 844"  data: yes]

Comment 4

[Valentina Virlics [:vvalentina], Ecosystem QA]

Attachment: Capture,-Explain-and-Send-Screenshots_v8.1.2.xpi

A similar issue is happening again. 
Verified on FF 48.0a2 and FF49.0a1
Please see the screenshot: http://screencast.com/t/Us9zXr5JZIg
Attaching the used web-extension.

Can you see an error in the messages.json, [e-mail] ?

Comment 5

[Kris Maglione [:kmag]]

Apparently our JSON parser treats tabs in strings as control characters. That should probably be a separate platform bug rather than a WebExtension bug.

Comment 6

[Kris Maglione [:kmag]]

Actually, it turns out that that's the expected behavior.