1272599 - [UI Events-key] Rename "MozHomeScreen", "MozCameraFocusAdjust" and "MozPhoneCall" key values to "GoHome", "CameraFocus" and "Call"

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Latest UI Events KeyboardEvent key values define new key values which are currently defined with "Moz" prefix. We should rename them, but I don't know a good person of Gaia who I should notify of this change.

Smaug, do you know?

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Perhaps fabrice?

But if we don't want to be blocked on b2g cleanups, could we implement the new stuff with #ifndef MOZ_B2G and leave the old stuff with #ifdef MOZ_B2G ?

Comment 2

[[:fabrice] Fabrice Desré]

Olli, I checked gaia and we don't use MozPhoneCall anywhere. So I would go with #ifdef/#ifndef MOZ_B2G for MozHomeScreen and MozCameraFocusAdjust, and just rename MozPhoneCall.

That would be great if you could also file a bug in Gaia::General once this one is fixed to remind us to make the other changes. Thanks!

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=48f979b9190c

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c300c5bdcfab

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bee82d7073c7

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: MozReview Request: Bug 1272599 part.1 Rename KeyboardEvent.key value, "MozPhoneCall" to "Call" r?smaug

Android's KEYCODE_CALL was temporarily named as "MozPhoneCall" since proper key name was not defined in the spec. However, now, it's defined as "Call" in the latest spec. Therefore, we should rename this key name.

Note that this isn't available on Android because the key event is never fired on applications. However, this key may be useful on B2G. Although, the key is not used by current Gaia.

Review commit: https://reviewboard.mozilla.org/r/54406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54406/

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: MozReview Request: Bug 1272599 part.2 Rename KeyboardEvent.key values, "MozHomeScreen" and "MozCameraFocusAdjust" to "GoHome" and "CameraFocus" except on B2G r?smaug

KEYCODE_HOME was temporarily named as "MozHomeScreen" and KEYCODE_FOCUS was temprarily named as "MozCameraFocusAdjust" since they were not defined by the spec. However, in the latest spec, they are defined as "GoHome" and "CameraFocus". So, it is the time to rename them.

However, these temporary key names are still used by Gaia. Until it's fixed, we should keep using the temporary names only on B2G.

Review commit: https://reviewboard.mozilla.org/r/54408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54408/

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8755674 [details]
MozReview Request: Bug 1272599 part.1 Rename KeyboardEvent.key value, "MozPhoneCall" to "Call" r?smaug

https://reviewboard.mozilla.org/r/54406/#review51456

ok, so we can do the renaming because the name isn't used anywhere currently.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8755675 [details]
MozReview Request: Bug 1272599 part.2 Rename KeyboardEvent.key values, "MozHomeScreen" and "MozCameraFocusAdjust" to "GoHome" and "CameraFocus" except on B2G r?smaug

https://reviewboard.mozilla.org/r/54408/#review51458

I see, we have already DEFINE_KEYNAME_WITH_SAME_NAME(GoHome) and such.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d50ff85ea0db
https://hg.mozilla.org/integration/mozilla-inbound/rev/7562ee87e961

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d50ff85ea0db
https://hg.mozilla.org/mozilla-central/rev/7562ee87e961

Comment 12

[Eric Shepherd [:sheppy]]

Updated Firefox 49 for developers. I have a question in to :masayuki about some existing content in the key event docs that I need to clarify before I update the KeyboardEvent.key and KeyboardEvent.code pages as necessary; there are some things on this page that need to be cleaned up.

Comment 13

[Eric Shepherd [:sheppy]]

KeyboardEvent.key is updated. These keys are not currently on KeyboardEvent.code; if they need to be, the process of revising the page will get them added. See bug 1296444 for that refactor.