"Share" icon from Action Bar is displayed smaller than the rest of the icons

VERIFIED FIXED in Firefox 49

Status

()

Firefox for Android
General
VERIFIED FIXED
2 years ago
a year ago

People

(Reporter: TeoVermesan, Assigned: ahunt)

Tracking

49 Branch
Firefox 49
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox48 unaffected, firefox49 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

2 years ago
Created attachment 8752192 [details]
Screenshot from 2016-05-13 16:26:42.png

Steps to reproduce:
1. Visit: http://en.wikipedia.org/wiki/mozilla
2. Tap press-hold on a selected word such as: 'Mozilla'

Expected results:
- The action bar is displayed correctly with all available options

Actual results:
- Share icon is displayed smaller than the rest of the icons
(Reporter)

Comment 1

2 years ago
Created attachment 8752207 [details]
Screenshot from 2016-05-13 17:18:37.png

The same is with "Share" option from Menu.
bug 1269774 touched the share icon. maybe fallout from that bug?
Flags: needinfo?(ahunt)
(Assignee)

Comment 3

2 years ago
Yup, we were experimenting with the padding of the share icon, that should've been reverted but slipped through the cracks.
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Flags: needinfo?(ahunt)
(Assignee)

Comment 4

2 years ago
Created attachment 8753945 [details]
MozReview Request: Bug 1272659 - Revert additional padding for the share icon r?mcomella

We were experimenting with this on phones, however we decided this
was unnecessary.

Review commit: https://reviewboard.mozilla.org/r/53598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53598/
Attachment #8753945 - Flags: review?(michael.l.comella)
Comment on attachment 8753945 [details]
MozReview Request: Bug 1272659 - Revert additional padding for the share icon r?mcomella

https://reviewboard.mozilla.org/r/53598/#review50794

This change makes no sense on reviewboard (just a bunch of file renames) but the file renames seem reasonable.
Attachment #8753945 - Flags: review?(michael.l.comella) → review+
(Assignee)

Comment 6

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/5b17c3dacc25f65c82dfdb09bff09de96f17079d
Bug 1272659 - Revert additional padding for the share icon r=mcomella

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5b17c3dacc25
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49

Comment 8

2 years ago
Tested using:
Device: Alcatel Onetouch (Android 4.1.2)
Build: Firefox for Android Nightly 49.0a1 (2016-05-24)

Updated

2 years ago
status-firefox49: fixed → verified

Comment 9

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/378c67747196

Comment 10

a year ago
I'm changing the status to verified fixed considering that the bug is verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.