Closed
Bug 1272659
Opened 8 years ago
Closed 8 years ago
"Share" icon from Action Bar is displayed smaller than the rest of the icons
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox48 unaffected, firefox49 verified)
VERIFIED
FIXED
Firefox 49
Tracking | Status | |
---|---|---|
firefox48 | --- | unaffected |
firefox49 | --- | verified |
People
(Reporter: TeoVermesan, Assigned: ahunt)
Details
Attachments
(3 files)
Steps to reproduce: 1. Visit: http://en.wikipedia.org/wiki/mozilla 2. Tap press-hold on a selected word such as: 'Mozilla' Expected results: - The action bar is displayed correctly with all available options Actual results: - Share icon is displayed smaller than the rest of the icons
Reporter | ||
Comment 1•8 years ago
|
||
The same is with "Share" option from Menu.
Comment 2•8 years ago
|
||
bug 1269774 touched the share icon. maybe fallout from that bug?
Flags: needinfo?(ahunt)
Assignee | ||
Comment 3•8 years ago
|
||
Yup, we were experimenting with the padding of the share icon, that should've been reverted but slipped through the cracks.
Assignee: nobody → ahunt
Status: NEW → ASSIGNED
Flags: needinfo?(ahunt)
Assignee | ||
Comment 4•8 years ago
|
||
We were experimenting with this on phones, however we decided this was unnecessary. Review commit: https://reviewboard.mozilla.org/r/53598/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53598/
Attachment #8753945 -
Flags: review?(michael.l.comella)
Comment on attachment 8753945 [details] MozReview Request: Bug 1272659 - Revert additional padding for the share icon r?mcomella https://reviewboard.mozilla.org/r/53598/#review50794 This change makes no sense on reviewboard (just a bunch of file renames) but the file renames seem reasonable.
Attachment #8753945 -
Flags: review?(michael.l.comella) → review+
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/5b17c3dacc25f65c82dfdb09bff09de96f17079d Bug 1272659 - Revert additional padding for the share icon r=mcomella
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5b17c3dacc25
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment 8•8 years ago
|
||
Tested using: Device: Alcatel Onetouch (Android 4.1.2) Build: Firefox for Android Nightly 49.0a1 (2016-05-24)
Updated•8 years ago
|
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/378c67747196
Comment 10•8 years ago
|
||
I'm changing the status to verified fixed considering that the bug is verified.
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•