|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
178.64 KB, image/png
90.98 KB, image/png
58 bytes, text/x-review-board-request
|Details | Review|
Created attachment 8752192 [details] Screenshot from 2016-05-13 16:26:42.png Steps to reproduce: 1. Visit: http://en.wikipedia.org/wiki/mozilla 2. Tap press-hold on a selected word such as: 'Mozilla' Expected results: - The action bar is displayed correctly with all available options Actual results: - Share icon is displayed smaller than the rest of the icons
Created attachment 8752207 [details] Screenshot from 2016-05-13 17:18:37.png The same is with "Share" option from Menu.
bug 1269774 touched the share icon. maybe fallout from that bug?
Yup, we were experimenting with the padding of the share icon, that should've been reverted but slipped through the cracks.
Created attachment 8753945 [details] MozReview Request: Bug 1272659 - Revert additional padding for the share icon r?mcomella We were experimenting with this on phones, however we decided this was unnecessary. Review commit: https://reviewboard.mozilla.org/r/53598/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/53598/
Comment on attachment 8753945 [details] MozReview Request: Bug 1272659 - Revert additional padding for the share icon r?mcomella https://reviewboard.mozilla.org/r/53598/#review50794 This change makes no sense on reviewboard (just a bunch of file renames) but the file renames seem reasonable.
https://hg.mozilla.org/integration/fx-team/rev/5b17c3dacc25f65c82dfdb09bff09de96f17079d Bug 1272659 - Revert additional padding for the share icon r=mcomella
Tested using: Device: Alcatel Onetouch (Android 4.1.2) Build: Firefox for Android Nightly 49.0a1 (2016-05-24)
I'm changing the status to verified fixed considering that the bug is verified.