1272673 - make app.psgi runnable, fix static path regex to efficient, and make @INC contain absolute paths.

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Description

[Dylan Hardison [:dylan] (he/him)]

To use plackup for development, it is required to pass several paths using -R so that when files change, the service is restarted. Rather than burden the documentation with this, we should have a wrapper that runs it with the correct parameters for development.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

We should also force taint mode on. This will look for a system "plackup" before using one installed in local/bin.

Comment 2

[olga-github]

Attachment: launchbugzilla

The script launchbugzilla starts Bugzilla from a Git clone locally.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Attachment: run-bugzilla

Olga: Check if my modification of the script works for you?

(attached)

Comment 4

[olga-github]

dylan: I've tried it and it didn't work. Here's the error message:

olga@yellow:~/bugzilla$ ./run-bugzilla 
Can't open perl script "./local/lib/perl5": Is a directory
olga@yellow:~/bugzilla$

Comment 5

[olga-github]

Attachment: runbugzilla

Fixed script launch-bugzilla
Still, script can't be launched.
When trying to launch, following error message appears:

olga@yellow:~/bugzilla$ ./runbugzilla 
Can't open perl script ". plackup": No such file or directory
olga@yellow:~/bugzilla$ 

How can I get the script to run properly?

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Attachment: bzup

another try, this time I used perl.

1) Uses FindBin to find the directory the script is in
2) Adds the $FindBin::Bin/local/bin to PATH
3) Uses $^X, which is the same executable that is running the script (usually /usr/bin/perl)
4) Uses -S, which means it looks for plackup in the PATH. So if plack and stuff
are installed outside of local, this script will still work.

I also named it "bzup"

usage should be:

chmod a+x ./bzup; ./bzup

Comment 7

[GitHub Autolander Bot]

Attachment: [bugzilla] dylanwh:experimental > bugzilla:master

Comment 8

[GitHub Autolander Bot]

Attachment: [bugzilla] dylanwh:bug-1272673 > bugzilla:master

Comment 9

[Dylan Hardison [:dylanAtHome]]

Comment on attachment 8841282 [details] [review]
[bugzilla] dylanwh:bug-1272673 > bugzilla:master

The pull request does three things that are pretty non-controversial:

1) it makes it so @INC contains only absolute paths, and also disables 'use lib' (copying the behavior from mod_perl.pl)
2) For the static file handling, it sorts the regex by length, which gurantees that the regex match more efficiently. This was inspired by what the wonderful list2re() function of Data::Munge does. https://metacpan.org/pod/Data::Munge#list2re-LIST
3) Finally, it users caller() to detect if it is being run on the command line, and if so it runs itself. So we don't need the user to type a weird complicated command, they just run "perl app.psgi".

This is the recommended way of making a self-runnable psgi, per the documentation:
https://metacpan.org/pod/Plack::Runner#NOTES

Comment 10

[Dylan Hardison [:dylanAtHome]]

To [e-mail]:bugzilla/bugzilla.git
   dfb688869..c6363140a  master -> master