1272748 - expose --enable-sm-promise in mozinfo

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

Bug 911216 introduced an --enable-sm-promise config flag.  The streams work in bug 1272697 is also going to depend on this flag.  I'd like to mark the wpt tests in that bug dependent on this build configuration.

Therefore, I'd like to expose 'sm_promise' as a boolean in mozinfo.json.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Expose --enable-sm-promise config setting in mozinfo.json. r=ted

See comment 0 for why I'd like to make this change.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8752303 [details] [diff] [review]
Expose --enable-sm-promise config setting in mozinfo.json. r=ted

Ted is just getting back from PTO.  Mike, can you take a look at this?  Thanks!

Comment 3

[Michael Shal [:mshal]]

Comment on attachment 8752303 [details] [diff] [review]
Expose --enable-sm-promise config setting in mozinfo.json. r=ted

Can you document 'sm_promise' in build/docs/mozinfo.rst?

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Expose --enable-sm-promise config setting in mozinfo.json. r=mshal

Comment 5

[Michael Shal [:mshal]]

Comment on attachment 8752325 [details] [diff] [review]
Expose --enable-sm-promise config setting in mozinfo.json. r=mshal

>+sm_promise
>+   Whether spidermonkey promises have been enabled or not.  This is set
>+   by add --enable-sm-promise in the mozconfig.

nit: add -> adding ?

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60dd109c038b

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/60dd109c038b