bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Quick search engine bar cut off when additional system status bar is active

NEW
Unassigned

Status

()

Firefox for iOS
Browser
2 years ago
2 years ago

People

(Reporter: malayaleecoder, Unassigned)

Tracking

({reproducible})

unspecified
Other
iOS
reproducible

Firefox Tracking Flags

(fxios+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

2 years ago
Created attachment 8752327 [details]
Screenshot

Platform : iPhone SE (9.3.1)
Firefox Version : 4.0 (11)

Steps to Reproduce:

1. Make iPhone act as a Personal Hotspot and connect a device to that network.
2. Open Firefox and type anything in the search bar.

The Quick Search Engine bar is seen cut off.
(Reporter)

Comment 1

2 years ago
Created attachment 8752328 [details]
Screenshot(updated)

Personal Hotspot connection banner was not visible in the previous attachment.
Attachment #8752327 - Attachment is obsolete: true
Also visible with an in-call status bar, tested in simulator.

Thanks for the report. Wonder what we can do?
tracking-fxios: --- → ?
Keywords: reproducible
Summary: Quick Search Engine bar seen cut off when acting as a Personal Hotspot → Quick search engine bar cut off when additional system status bar is active
Created attachment 8752863 [details]
in-call-status-bar-screenshot

Updated

2 years ago
See Also: → bug 1273155
Steph mentioned wanting to look into this.
Rank: 6
tracking-fxios: ? → +
Flags: needinfo?(sleroux)
Doesn't seem to be related to the notification status bar work I've been doing since this was found on 4.0. We don't account for the extended status bar height when calculating the offset we need to show the search engine bar while the keyboard is up. I'll file a patch with it. 

However, this exposes a larger issue across our app. We have a lot of view controllers that implement the KeyboardHelper/Delegate combination to determine offsets from the keyboard appearing. We use a lot of table views in the app when showing the keyboard and by using UITableViewController instead of UIViewController subclasses we actually get this calculation for free. The table view will automatically shrink/expand to compensate for the keyboard height which would eliminate the need to match animations and move things around. I would expand on this bug to move towards using UITableViewController but since this implements SiteTableViewController that becomes a much larger task. In the future, we should try to use UITableViewController when we can to get this free functionality and in cases that we can't, try to mimic the behavior of shrinking/expanding the content view instead of shifting elements around.
Flags: needinfo?(sleroux)
You need to log in before you can comment on or make changes to this bug.