1272819 - Recommended driver versions are exposed as failure ids

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

I get the following histogram of failure ids from telemetry:
defaultdict(int,
            {u'6.14.10.5218': 1,
             u'8.15.10.2342': 6,
             u'FEATURE_FAILURE_AMD1': 21,
             u'FEATURE_FAILURE_DL_BLACKLIST_g1071': 1,
             u'FEATURE_FAILURE_DL_BLACKLIST_g1072': 1,
             u'FEATURE_FAILURE_DL_BLACKLIST_g1124': 2,
             u'FEATURE_FAILURE_INTEL_14': 1,
             u'FEATURE_FAILURE_INTEL_2': 1,
             u'FEATURE_FAILURE_INTEL_20': 1,
             u'FEATURE_FAILURE_INTEL_22': 3,
             u'FEATURE_FAILURE_INTEL_5': 7,
             u'FEATURE_FAILURE_INTEL_WEBGL_DIS': 28,
             u'FEATURE_FAILURE_NV_VISTA': 1,
             u'FEATURE_FAILURE_NV_W7': 6,
             u'FEATURE_FAILURE_NV_XP': 1,
             u'FEATURE_FAILURE_TEST': 8,
             u'FEATURE_FAILURE_WEBGL_ATI_DIS': 2,
             u'OK': 12})

8.15.10.2342 etc. suggests that we're misinterpreting the recommend driver version as the failure code.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: MozReview Request: Bug 1272819 - Fix failureid/version mixup. r=jrmuizel

Review commit: https://reviewboard.mozilla.org/r/54934/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54934/

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8756043 [details]
MozReview Request: Bug 1272819 - Fix failureid/version mixup. r=jrmuizel

https://reviewboard.mozilla.org/r/54934/#review51616

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c08a10627942

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c08a10627942