1272831 - Add AutoRestore::Value() to retrieve the saved value

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

AutoRestore::Value() would help in uses cases like [1].

https://dxr.mozilla.org/mozilla-central/rev/1f1a8b96d5167153d1f750439ba6a1063155a4bc/layout/generic/nsBlockReflowState.cpp#721-723

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1272831 - Add AutoRestore::SavedValue() to retrieve the saved value.

Review commit: https://reviewboard.mozilla.org/r/52607/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52607/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8752428 [details]
MozReview Request: Bug 1272831 - Add AutoRestore::SavedValue() to retrieve the saved value.

https://reviewboard.mozilla.org/r/52607/#review50330

r=me with changes below.

::: xpcom/glue/AutoRestore.h:47
(Diff revision 1)
>    }
>    ~AutoRestore()
>    {
>      mLocation = mValue;
>    }
> +  T Value() const

This is fine, but I think we should call it SavedValue, to avoid ambiguity about whether we're reading from the location that we're going to restore or the value that we're going to restore.

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8752428 [details]
MozReview Request: Bug 1272831 - Add AutoRestore::SavedValue() to retrieve the saved value.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52607/diff/1-2/

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

https://reviewboard.mozilla.org/r/52607/#review50330

> This is fine, but I think we should call it SavedValue, to avoid ambiguity about whether we're reading from the location that we're going to restore or the value that we're going to restore.

Changed the name to SavedValue() in patchset 2.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/017017aeacf1

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/017017aeacf1