1272938 - compile error in testThreadingThread

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Singer (:stevensn)]

Building on my  non-ion platform gives the following error

js/src/jsapi-tests/testThreadingThread.cpp:43:28: error: \u2018ThisThread\u2019 has not been declared
 0:52.20      js::Thread thread([](){ThisThread::SetName("JSAPI Test Thread");});

among other places where the js:: namespace isn't explicitly referenced in this file

Comment 1

[Steve Singer (:stevensn)]

Attachment: Add explicit using namespace js

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8752538 [details] [diff] [review]
Add explicit using namespace js

Review of attachment 8752538 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi-tests/testThreadingThread.cpp
@@ +11,5 @@
>  #include "mozilla/Vector.h"
>  #include "jsapi-tests/tests.h"
>  #include "threading/Thread.h"
>  
> +using namespace js;

The reason this broke in the first place is that this file got unified in my build with a file with this declaration, but not in yours. We should just add the js:: to the relevant declarations instead.

Comment 3

[Terrence Cole [:terrence]]

Oh, note that you can test for similar bustage easily by setting FILES_PER_UNIFIED_FILE=1 in the moz.build (current value 6). We intermittently clean up this build configuration, but it's not something that happens continuously.

Comment 4

[Steve Singer (:stevensn)]

Attachment: Add js namespace prefix

Comment 5

[Steve Singer (:stevensn)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fa395147d72a

Comment 6

[Terrence Cole [:terrence]]

Comment on attachment 8753143 [details] [diff] [review]
Add js namespace prefix

Review of attachment 8753143 [details] [diff] [review]:
-----------------------------------------------------------------

That's perfect, thank you for the patch!

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/035efa5e0655

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/035efa5e0655