Closed Bug 1272959 Opened 9 years ago Closed 9 years ago

MSE SkipVideoDemuxToNextKeyFrame frames skipped reported is wrong

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID
Tracking Flags:
Tracking Status
firefox49 --- affected

People

(Reporter: jya, Unassigned)

References

Details

MediaSourceDemuxer::SkipVideoDemuxToNextKeyFrame is always called after a reset, so the next sample demuxed will be the first one. But SkipVideoDemuxToNextKeyFrame will count as dropped frames all frames until the first keyframe past the threshold is found. Additionally, the MSE SkipVideoDemuxToNextKeyFrame check that the time threshold is buffered is incorrect too, as it's the next keyframe time we should check (but that we don't know). SkipVideoDemuxToNextKeyFrame could incorrectly jump over any gap and end up well pass the time threshold. So we should use the same logic as per bug 1272916, and ensure we don't go over gaps ; however stalling may not be the best thing to do as currentTime would be incorrectly in the past of where we've actually stalled.
My analysis was wrong, the demuxer isn't reset. Will follow up with another bug to fix issue mentioned #2
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → INVALID
No longer blocks: MSE
You need to log in before you can comment on or make changes to this bug.