1272970 - test_transitions_per_property.html failure after enable MOZ_ENABLE_MASK_AS_SHORTHAND

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[u459114]

Test case failed after mask-position become a shorthand property[1].
Failure message:
layout/style/test/test_transitions_per_property.html | uncaught exception - NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057

[1] https://hg.mozilla.org/mozilla-central/diff/c0a618d9fa6f/layout/style/nsCSSPropList.h#l2737

Comment 1

[u459114]

Attachment: MozReview Request: Bug 1272970 - fix test_transitions_per_property failure;

Review commit: https://reviewboard.mozilla.org/r/52656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52656/

Comment 2

[u459114]

mochitest failure
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc1e1a8f5635&selectedJob=20853146

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8752591 [details]
MozReview Request: Bug 1272970 - fix test_transitions_per_property failure;

https://reviewboard.mozilla.org/r/52656/#review49576

Hmm, do we invalidate correctly for dynamic changes to mask-position? If not, we may need to convert nsChangeHint_UpdateBackgroundPosition to nsChangeHint_RepaintFrame in the change handling for masks.

Comment 4

[u459114]

Too bad, the answer is no. I am going to figure it out.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1cd4b0a23342

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1cd4b0a23342