Recieved replies to not (anymore) existing events trigger a misleading message in imipBar

RESOLVED FIXED in 5.2

Status

Calendar
E-mail based Scheduling (iTIP/iMIP)
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

Tracking

Lightning 4.7

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
If you receive a reply to a previously sent out invitation from an attendee and the corresponding event doesn't exist anymore in any of the then available calendars, in the imip bar the standard message "This message contains an event that this version of Lightning cannot process." is displayed. This should be more accurate to reflect the actual situation.

STR:
1. create an event and invite an attendee
2. Make sure you sent out the invitation
3. Delete the event from the calendar, but make sure to not send out the cancellation
4. Receive a reply to the original invitation from the attendee
(Assignee)

Comment 1

2 years ago
Created attachment 8752604 [details] [diff] [review]
ReplyToNotExistingEvent-V1.diff

This adds two new label depending on whether we still have the event in the deleted events database or not.
Attachment #8752604 - Flags: review?(philipp)
Comment on attachment 8752604 [details] [diff] [review]
ReplyToNotExistingEvent-V1.diff

Review of attachment 8752604 [details] [diff] [review]:
-----------------------------------------------------------------

::: calendar/locales/en-US/chrome/lightning/lightning.properties
@@ +121,5 @@
>  imipBarUpdateText=This message contains an update to an existing event.
>  imipBarAlreadyProcessedText=This message contains an event that has already been processed.
>  imipBarProcessedNeedsAction=This message contains an event that you have not yet responded to.
>  imipBarReplyText=This message contains a reply to an invitation.
> +imipBarReplyToNotExistingItem=This message contains a reply to an invitation referring to an event that is not in your calendar.

Maybe shorten this to "This message contains a reply referring to an event that is not in your calendar.". Same with the other string.

@@ +124,5 @@
>  imipBarReplyText=This message contains a reply to an invitation.
> +imipBarReplyToNotExistingItem=This message contains a reply to an invitation referring to an event that is not in your calendar.
> +# LOCALIZATION_NOTE(imipBarReplyToRecentlyRemovedItem):
> +# %1$S - datetime of deletion
> +imipBarReplyToRecentlyRemovedItem=This message contains a reply to an invitation referring to an event that was removed from your calendar at %1$S.

Hmm, I'm not sure how useful it would be for the user to know when the item was removed. Maybe we could just use the first string in both cases?
Attachment #8752604 - Flags: review?(philipp) → review+
(Assignee)

Comment 3

2 years ago
I changes the strings accordingly, but left it with to separate strings. If we have the information, we also should show it, imho. We have a similar mechanism in the imip bar when your going to accept an invitation for an ecent you deleted recently (although without mentioning the exact date).

https://hg.mozilla.org/comm-central/rev/0c0143fa38d8456115d2331c71fb72fb3d05c7c8
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 5.2
(Assignee)

Updated

2 years ago
Depends on: 1291421
You need to log in before you can comment on or make changes to this bug.