1273072 - [Static Analysis][Uninitialized pointer field] In constructor WebIDLNameTableEntry(KeyTypePointer aKey)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andi [:andi]]

The Static Analysis tool Coverity added that variables |mNameOffset|, |mNameLength|, |mDefine|, |mEnabled|. As we are trying to push for a more RAII architecture and we want to prepare our code for this clang-plugin - 525063. We should initialize these variables.

Comment 1

[Andi [:andi]]

Attachment: MozReview Request: Bug 1273072 - initialize |mNameOffset|, |mNameLength|, |mDefine|, |mEnabled|. r?jst

Review commit: https://reviewboard.mozilla.org/r/52750/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52750/

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 8752720 [details]
MozReview Request: Bug 1273072 - initialize |mNameOffset|, |mNameLength|, |mDefine|, |mEnabled|. r?jst

Redirecting review to peterv who understands the tradeoffs here better than I do.

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 8752720 [details]
MozReview Request: Bug 1273072 - initialize |mNameOffset|, |mNameLength|, |mDefine|, |mEnabled|. r?jst

https://reviewboard.mozilla.org/r/52750/#review50726

Hmm, this is a rather useless initialization since the fields will be overwritten right away.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5109a152a771

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5109a152a771