[Static Analysis][Uninitialized scalar field] In constructor explicit Compositor

RESOLVED FIXED in Firefox 49

Status

()

Core
Graphics
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: andi, Assigned: andi)

Tracking

(Blocks: 1 bug, {coverity})

Trunk
mozilla49
coverity
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

(Whiteboard: CID 1361793 )

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
The Static Analysis tool Coverity added that variables |mPixelsPerFrame|, |mPixelsFilled| are uninitialized. As we are trying to push for a more RAII architecture and we want to prepare our code for this clang-plugin - 525063. We should initialize these member variables.
(Assignee)

Comment 1

2 years ago
Created attachment 8752734 [details]
MozReview Request: Bug 1273075 - initialize |mPixelsPerFrame| and |mPixelsFilled|. r?jrmuizel

Review commit: https://reviewboard.mozilla.org/r/52754/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52754/
Attachment #8752734 - Flags: review?(jmuizelaar)
Comment on attachment 8752734 [details]
MozReview Request: Bug 1273075 - initialize |mPixelsPerFrame| and |mPixelsFilled|. r?jrmuizel

https://reviewboard.mozilla.org/r/52754/#review49714
Attachment #8752734 - Flags: review?(jmuizelaar) → review+

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ee5016917ea1
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.