1273148 - Take away gfxPref's friend (and remove a reason for any future ones)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

Bug 1254899 part 10 made gfxWindowsPlatform a friend of gfxPrefs - it seems the access to the preference name and default value is going to be needed in more places (e.g., bug 1272808), so instead of making more friends, we should remove this one and make those (getter) methods public.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: MozReview Request: Bug 1273148: Make name and default methods public, and remove gfxWindowsPlatform as gfxPref's friend. r?dvander

Review commit: https://reviewboard.mozilla.org/r/52820/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52820/

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8752840 [details]
MozReview Request: Bug 1273148: Make name and default methods public, and remove gfxWindowsPlatform as gfxPref's friend. r?dvander

https://reviewboard.mozilla.org/r/52820/#review49738

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cdcb63c7627d

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cdcb63c7627d