127318 - Need to push UserInGroup to templates

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P1)

Description

[Bradley Baetz (:bbaetz)]

The sidebar xul stuff fails because UserInGroup is not pushed to the template.
This should be added globally so that other templates can use it (although they
should be caching it for speed reasons)

Comment 1

[Bradley Baetz (:bbaetz)]

-> me, patch coming, 2.16 blocker.

Comment 2

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 3

[Jacob Steenhagen]

Comment on attachment 70976 [details] [diff] [review]
patch

>Index: globals.pl
>+    # UserInGroup - you probably want to cache this....\

Got an extra '\' in there that should probably go :)

Other than that, r=jake x2

PS, sidebar/xul.tmpl only calls this once per group so it doesn't need a cache.

Comment 4

[Matthew Tuck [:CodeMachine]]

Why are we doing this in templates?  I would say in all situations the security
stuff should be done before sending to the template.

Comment 5

[Bradley Baetz (:bbaetz)]

Its not security stuff per se. The sidebar needs to know whterh to show the
edit* links, just like the footer does. This keeps the idea of what we're
searching for closer to the template - theres no need to use indirection just
for the sake of indirection.

I agree that security settings and stuff like what fields to show on enter_bug
belong in the perl, not the template, but thats not the issue here. Once
commandmenu is templatised, then this would also use that, which is why its in
globals and not sidebar.cgi.

Comment 6

[Bradley Baetz (:bbaetz)]

I'll leave this for a couple of days, see what other people think, before
committing.

Comment 7

[Matthew Tuck [:CodeMachine]]

In which case shouldn't the links be moved into a separate template?

Comment 8

[Bradley Baetz (:bbaetz)]

No. for the footer, they are separated by html tags, and the sidebar uses xul.
Sure, we could pass in pre/post params, and do it that way, but I think that
thats excessive.

Comment 9

[Bradley Baetz (:bbaetz)]

justdave didn't have a problem with this; checked in