Don't allow reloading on about:debugging for unsupported add-ons

VERIFIED FIXED in Firefox 49

Status

defect
P2
normal
VERIFIED FIXED
3 years ago
10 months ago

People

(Reporter: kumar, Assigned: kumar)

Tracking

(Blocks 1 bug, {dev-doc-complete})

Trunk
Firefox 49

Firefox Tracking Flags

(firefox49 verified)

Details

Attachments

(1 attachment)

As of bug 1269889, only temporarily installed add-ons can be reloaded. The about:debugging UI should disable the Reload button for all other types of add-ons.
Assignee: nobody → kumar.mcmillan
Blocks: 1226743
Attachment #8753047 - Flags: review?(poirot.alex)
Comment on attachment 8753047 [details]
MozReview Request: Bug 1273184 - Don't allow reloading of unsupported add-ons. r=ochameau

https://reviewboard.mozilla.org/r/52954/#review50040

::: devtools/client/aboutdebugging/components/addons/target.js:62
(Diff revision 1)
>        }, Strings.GetStringFromName("debug")),
>        dom.button({
>          className: "reload-button",
> -        onClick: this.reload
> +        onClick: this.reload,
> +        // Only temporarily installed add-ons can be reloaded.
> +        disabled: !target.temporarilyInstalled

I imagine it would be helpful to have a tooltip on the button to explain why it is disabled.
Comment on attachment 8753047 [details]
MozReview Request: Bug 1273184 - Don't allow reloading of unsupported add-ons. r=ochameau

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52954/diff/1-2/
Attachment #8753047 - Attachment description: MozReview Request: Bug 1273184 - Don't allow reloading of unsupported add-ons. r?ochameau → MozReview Request: Bug 1273184 - Don't allow reloading of unsupported add-ons. r=ochameau
Attachment #8753047 - Flags: review?(poirot.alex)
https://reviewboard.mozilla.org/r/52954/#review50040

> I imagine it would be helpful to have a tooltip on the button to explain why it is disabled.

ah, true. I added a tooltip
Attachment #8753047 - Flags: review?(poirot.alex) → review+
Comment on attachment 8753047 [details]
MozReview Request: Bug 1273184 - Don't allow reloading of unsupported add-ons. r=ochameau

https://reviewboard.mozilla.org/r/52954/#review50132

Works great, thanks!
Reloading in about:debugging only works for Add-ons installed with the "Load Temporary Add-on" button.
Keywords: dev-doc-needed
Priority: -- → P2

Comment 9

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/18f8aacfdc9d
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
I've added a note to the following page to make this clear:

https://developer.mozilla.org/en-US/docs/Tools/about:debugging#Firefox_48_onwards

I've also added a note to the Fx 49 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/49#Developer_Tools

Let me know if you think this needs anything else. Thanks!
I was able to reproduce the initial issue on Firefox 48.0.2 (20160823121617) under Windows 10 64-bit.

Verified fixed on Firefox 49 (20160912134115), Firefox 50.0a2 (2016-09-15) and Firefox 51.0a1 (2016-09-15) under Windows 10 64-bit. Only temporarily installed add-ons can be reloaded.
Status: RESOLVED → VERIFIED

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.