1273184 - Don't allow reloading on about:debugging for unsupported add-ons

Status: VERIFIED FIXED

(DevTools :: about:debugging, defect, P2)

Description

[Kumar McMillan [:kumar]]

As of bug 1269889, only temporarily installed add-ons can be reloaded. The about:debugging UI should disable the Reload button for all other types of add-ons.

Comment 1

[Kumar McMillan [:kumar]]

Attachment: MozReview Request: Bug 1273184 - Don't allow reloading of unsupported add-ons. r=ochameau

Review commit: https://reviewboard.mozilla.org/r/52954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52954/

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 8753047 [details]
MozReview Request: Bug 1273184 - Don't allow reloading of unsupported add-ons. r=ochameau

https://reviewboard.mozilla.org/r/52954/#review50040

::: devtools/client/aboutdebugging/components/addons/target.js:62
(Diff revision 1)
>        }, Strings.GetStringFromName("debug")),
>        dom.button({
>          className: "reload-button",
> -        onClick: this.reload
> +        onClick: this.reload,
> +        // Only temporarily installed add-ons can be reloaded.
> +        disabled: !target.temporarilyInstalled

I imagine it would be helpful to have a tooltip on the button to explain why it is disabled.

Comment 3

[Kumar McMillan [:kumar]]

Comment on attachment 8753047 [details]
MozReview Request: Bug 1273184 - Don't allow reloading of unsupported add-ons. r=ochameau

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/52954/diff/1-2/

Comment 4

[Kumar McMillan [:kumar]]

https://reviewboard.mozilla.org/r/52954/#review50040

> I imagine it would be helpful to have a tooltip on the button to explain why it is disabled.

ah, true. I added a tooltip

Comment 5

[Alexandre Poirot [:ochameau]]

Comment on attachment 8753047 [details]
MozReview Request: Bug 1273184 - Don't allow reloading of unsupported add-ons. r=ochameau

https://reviewboard.mozilla.org/r/52954/#review50132

Works great, thanks!

Comment 6

[Jan Keromnes [:janx]]

Reloading in about:debugging only works for Add-ons installed with the "Load Temporary Add-on" button.

Comment 7

[Kumar McMillan [:kumar]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b54b21d4e2ac&selectedJob=20978279 (the failures all look like unrelated flaky tests to me)

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/18f8aacfdc9d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/18f8aacfdc9d

Comment 10

[Chris Mills [:cmills]]

I've added a note to the following page to make this clear:

https://developer.mozilla.org/en-US/docs/Tools/about:debugging#Firefox_48_onwards

I've also added a note to the Fx 49 release notes:

https://developer.mozilla.org/en-US/Firefox/Releases/49#Developer_Tools

Let me know if you think this needs anything else. Thanks!

Comment 11

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce the initial issue on Firefox 48.0.2 (20160823121617) under Windows 10 64-bit.

Verified fixed on Firefox 49 (20160912134115), Firefox 50.0a2 (2016-09-15) and Firefox 51.0a1 (2016-09-15) under Windows 10 64-bit. Only temporarily installed add-ons can be reloaded.