1273203 - Remove the getStructuredData API from BrowserElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

It's not used, and it's using the microdata API, which we want to remove.

Comment 1

[Boris Zbarsky [:bzbarsky]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c709f2ecdcfc

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove the getStructuredData API from BrowserElement

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8753031 [details] [diff] [review]
Remove the getStructuredData API from BrowserElement

Review of attachment 8753031 [details] [diff] [review]:
-----------------------------------------------------------------

> Cu.import("resource://gre/modules/Task.jsm");
> Cu.import("resource://gre/modules/Microformats.js");

Can be removed too.
Basically I think you can revert the changes in bug 1195801.

::: dom/browser-element/BrowserElementChildPreload.js
@@ -1696,1 @@
>    _processMicroformatValue(field, value) {

_processMicroformatValue() and _processMicroformatItem() can be removed too.

::: dom/browser-element/BrowserElementParent.js
@@ -1207,5 @@
>        });
>      return req;
>    },
>  
> -  getStructuredData: defineDOMRequestMethod('get-structured-data'),

Also need to remove the "got-structured-data": this._gotDOMRequestResult entry in mmCalls.

Comment 4

[Boris Zbarsky [:bzbarsky]]

> _processMicroformatValue() and _processMicroformatItem() can be removed too.

Ah, good catch.  Removed those and the other bits.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9b23b61401f

Comment 6

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d236c9957bf4

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for breaking many mochitests related to IPC.

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/d236c9957bf45b47f9d7bfa1724caf0d328396cc
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=57615f0d66d842f9d8ea910dca40163273378699

Comment 8

[Boris Zbarsky [:bzbarsky]]

Hmm.  The try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=c709f2ecdcfc didn't have those issues, so I assume they come from addressing the review comments in comment 3.  :(

And indeed, those failing runs have stuff like:

07:56:03     INFO -  JavaScript error: chrome://global/content/BrowserElementChildPreload.js, line 1450: ReferenceError: Task is not defined

I thought I'd checked for uses of Task in there, but clearly I failed somehow.  :(  It needs to stay.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6104a65d2bef

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6104a65d2bef

Comment 11

[Mike Kaply [:mkaply]]

Should the test have been removed as well?

https://hg.mozilla.org/mozilla-central/filelog/f8e3b81a79f4/dom/browser-element/mochitest/file_microformats.html

Comment 12

[Boris Zbarsky [:bzbarsky]]

Er, the test support files?  Yes they should have.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/16150ec04e4d
followup.  Remove now-unused test support files.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/16150ec04e4d