1273207 - Nodes marked black early in sync CC

Status: RESOLVED INVALID

(Core :: XPCOM, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: My personal debug patch

This bug started as a clone of bug 1266882.

I am running a debug build of Thunderbird and I had to remove two MOZ_ASSERTs (see patch) since the were constantly crashing the program.

Quoting from bug 1266882 comment #27:

In a Thunderbird session of a few hours I got
  In a synch CC, no nodes should be marked black early on
24000 (24 thousand) times and
  Live nodes should all have been traversed
300 times. Something is wrong in that logic.

Current counts when filing this: bug 34000 and 45.

Comment 1

[Jorg K (CEST = GMT+2)]

Andrew, any interest in this bug?

My debug builds still crash and I have to compile with a special patch (see attached) to convert those MOZ_ASSERT into printf in order to work at all.

Of course I can provide CC logs if you require them.

Comment 2

[Jorg K (CEST = GMT+2)]

I don't know what this bug was marked [Thunderbird] in the title, the problem exists just the same in FF and I'm really surprised that no one has run into it.

Here is what I did:
1) Refreshed my local repository. Applied the enclosed patch. Built FF in debug mode.
2) Started FF with -p, created a "test" profile, opened the profile.
3) (Enabled the menu bar.) Even on the Nightly Start Page I already get
   hundreds of "CRASH!!! - In a synch CC, no nodes should be marked black early on."

Without the patch, FF would have just crashed.

Is no one else experiencing this problem? Doesn't anyone use debug builds? I don't get it, I would assume *all* developers are affected by this bug.

I NI'ed Andrew about 10 days ago, but there was no reaction so far. What else can I do to get someone interested.

It looks to me that there is a problem which is simply glossed over in release builds since the MOZ_ASSERT doesn't trigger.

Comment 3

[Jorg K (CEST = GMT+2)]

Grrr, sorry about the noise. My "debug patch" was 100% rubbish:

-      MOZ_ASSERT(!aFullySynchGraphBuild,
-                 "In a synch CC, no nodes should be marked black early on.");
+      // MOZ_ASSERT(!aFullySynchGraphBuild,
+                 // "In a synch CC, no nodes should be marked black early on.");
+      fprintf(stderr, "CRASH!!! - In a synch CC, no nodes should be marked black early on.\n");

It prints all the time without checking the condition.

My apologies.

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Jorg K (GMT+2, PTO during summer, NI me) from comment #3)
> It prints all the time without checking the condition.

Thanks for following up! Sorry, I should have looked at your patch. I'd been thinking about it, but I hadn't thought of anything yet, which is why I hadn't posted here.