1273252 - WARP WebGL is not disabled with failIfMajorPerformanceCaveat

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

We should not ship WARP until this is fixed or we have the potential to make Google Maps bad for people.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

[Tracking Requested - why for this release]: Ruining Google Maps performance would be bad.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: MozReview Request: Bug 1273252 - r?jrmuizel - WARP should hit

From 1aea1bd168d6a61165a1038c7debfa1d940c9896 Mon Sep 17 00:00:00 2001
 failIfMajorPerformanceCaveat.
---
 dom/canvas/WebGLContext.cpp | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

Review commit: https://reviewboard.mozilla.org/r/54334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54334/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8755021 [details]
MozReview Request: Bug 1273252 - r?jrmuizel - WARP should hit

https://reviewboard.mozilla.org/r/54334/#review51022

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Jeff, is this a recent regression? Was it a problem in Fx46? I use google maps on my win10 machine and do not see a perf issue. I am a week away from RC so unless this is a critical recent regression, I really doubt we will be able to get this uplifted to Beta47. Thanks!

Comment 5

[Kelsey Gilbert [:jgilbert]]

(In reply to Ritu Kothari (:ritu) from comment #4)
> Hi Jeff, is this a recent regression? Was it a problem in Fx46? I use google
> maps on my win10 machine and do not see a perf issue. I am a week away from
> RC so unless this is a critical recent regression, I really doubt we will be
> able to get this uplifted to Beta47. Thanks!

This is for people who get software WebGL. You're probably always getting hardware WebGL, so this bug has no effect for you.
Unfortunately, we uplifted WARP fixes into 47, so we really should take this as well.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8755021 [details]
MozReview Request: Bug 1273252 - r?jrmuizel - WARP should hit

Approval Request Comment
[Feature/regressing bug #]: 1260944
[User impact if declined]: Bad performance on Google Maps and similar sights
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low - this gets those users back to where they were before bug 1260944.
[String/UUID change made/needed]:

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8755021 [details]
MozReview Request: Bug 1273252 - r?jrmuizel - WARP should hit

This improves performance on Google Maps (recent regression), Beta47+

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hello Wes, could we get this patch uplifted to moz-beta, before I gtb 47.0b9 (Thursday)? Thanks!

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I'm having trouble getting this patch to apply to any branch. Can you doublecheck that the patch still applies to beta?

Comment 10

[Kelsey Gilbert [:jgilbert]]

Attachment: beta patch

Comment 11

[Kelsey Gilbert [:jgilbert]]

(In reply to Wes Kocher (:KWierso) from comment #9)
> I'm having trouble getting this patch to apply to any branch. Can you
> doublecheck that the patch still applies to beta?

This applies. I can try landing it tomorrow in case it doesn't build for some reason.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c4cf7fcd62d3

Comment 13

[Jeff Muizelaar [:jrmuizel]]

It looks like this has not landed on central or aurora yet.

Comment 14

[Kelsey Gilbert [:jgilbert]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #13)
> It looks like this has not landed on central or aurora yet.

Weird, yeah.

Comment 15

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8755021 [details]
MozReview Request: Bug 1273252 - r?jrmuizel - WARP should hit

Approval Request Comment
(see beta?/+ comments)

Comment 16

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69aaee1090d8

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8755021 [details]
MozReview Request: Bug 1273252 - r?jrmuizel - WARP should hit

Landed in beta, we want that in aurora too.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b0a5f5e149d2

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69aaee1090d8