1273341 - Don't attempt to sync tabs with a URL size greater than our maximum record size

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Mark Hammond [:markh] [:mhammond]]

Via bug 1235474, we see failures attempting to upload tab records with a huge URL - in some cases the maximum record size we attempt is ~56MB (it's not clear if this is a combination of records or a single record) - but there is some point where the URL is simply too big for us to successfully upload. We will continue to try and upload the record for as long as the tab remains open.

We should consider imposing a maximum size of the tab's URL, beyond which we just don't attempt to Sync it (possibly reporting a warning in the log at the time).

Comment 1

[Richard Newman [:rnewman]]

Attachment: MozReview Request: Bug 1273341 - Don't attempt to sync tabs with very long URLs. r?markh

Review commit: https://reviewboard.mozilla.org/r/53064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53064/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8753194 [details]
MozReview Request: Bug 1273341 - Don't attempt to sync tabs with very long URLs. r?markh

https://reviewboard.mozilla.org/r/53064/#review49888

I didn't expect that ;)

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8753194 [details]
MozReview Request: Bug 1273341 - Don't attempt to sync tabs with very long URLs. r?markh

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53064/diff/1-2/

Comment 4

[Mark Hammond [:markh] [:mhammond]]

https://reviewboard.mozilla.org/r/53064/#review49896

You keep sending 'em, I'll keep clicking to ship 'em!

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/4c709f7a03350ad5e36d0d726c8f12106ed2049d
Bug 1273341 - Don't attempt to sync tabs with very long URLs. r=markh

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4c709f7a0335