1273344 - Background tabs and tabs toolbar itself have different color in dark developer theme

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[arni2033]

>>>   My Info:   Win7_64, Nightly 49, 32bit, ID 20160511030221
STR:
1. Open many tabs to cause overflow in tabs toolbar
2. Select 1st tab
3. Scroll tabs list to the very end

AR:  Tabs and tabs toolbar itself have different color
ER:  Tabs should have the same color as tabs toolbar

This is regression from bug 1205330. Regression range:
> https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=2f4723efdf3aa222b2cdcd76daf17b5816c2f406&tochange=028990b642eb874f2a53d65b773182311bf3fba2

Comment 2

[Brian Grinstead [:bgrins]]

Those arrow scrollbar buttons are using a variable named --tab-background-color, and we missed changing that one to match in https://hg.mozilla.org/integration/fx-team/rev/028990b642eb#l1.28.  Helen, would you please be able to make a patch to update that to #272b35?

Comment 3

[Helen V. Holmes (:helenvholmes) (:✨)]

Attachment: devtheme-tabcolor.patch

--tab-background-color now equals #272b35

Checked in dxr, I think that .inc file is the only placed it needed changing.

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8753353 [details] [diff] [review]
devtheme-tabcolor.patch

Review of attachment 8753353 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks :).  Please make the commit message one line and get rid of the git junk at the end of it

Comment 5

[Helen V. Holmes (:helenvholmes) (:✨)]

Attachment: devtheme-tabcolor.patch

Git junk removed!

Comment 6

[Ryan VanderMeulen [:RyanVM]]

For future reference, try to use commit messages that describe what the patch is actually doing instead of just restating the problem being solved.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c88aa104ef07

Comment 8

[Helen V. Holmes (:helenvholmes) (:✨)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> For future reference, try to use commit messages that describe what the
> patch is actually doing instead of just restating the problem being solved.

Will do.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c88aa104ef07

Comment 10

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 49.0a1 (2016-05-11) on Windows 7 , 64 Bit!

This bug's fix is verified on latest Developer Edition (Aurora) which is 49.0a2 (2016-07-08).


Build ID  20160708004052 

User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:49.0) Gecko/20100101 Firefox/49.0

Comment 11

[Rezaul Huque Nayeem]

Reproduced this bug in firefox nightly 49.0a1 (2016-05-10) with ubuntu 16.04 (64 bit)

Verified as this bug fixed with latest firefox aurora 49.0a2 (Build ID: 20160726004006)
Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0