Closed Bug 1273369 Opened 9 years ago Closed 8 years ago

Intermittent e10s browser_webconsole_bug_613280_jsterm_copy.js | A promise chain failed to handle a rejection: - Error: operation not possible on dead CPOW

Categories

(DevTools :: Console, defect, P2)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(e10s+, firefox49 unaffected, firefox50 fixed, firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Tracking Flags:
Tracking Status
e10s + ---
firefox49 --- unaffected
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: philor, Assigned: kevchan85, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 1 obsolete file)

bug1273369_intermittent_webconsole_bug.diff
2.21 KB, patch
bgrins
: review+
Details | Diff | Splinter Review
tracking-e10s: --- → ?
Depends on: 1256850
Priority: -- → P3
Priority: P3 → P2
Hi mike, So looking through this log I found that it is associated to a file in dev tools. There is a line of code calling content.console.log(). Is that where the error could lie? I tried playing around with it but all the changes I have made just result in mor errors on my side. Any suggestions?
Flags: needinfo?(mconley)
(In reply to kevin from comment #17) > Hi mike, > So looking through this log I found that it is associated to a file in dev > tools. There is a line of code calling content.console.log(). Is that where > the error could lie? I tried playing around with it but all the changes I > have made just result in mor errors on my side. Any suggestions? Hi Kevin, yes that is probably the issue. You should be able to replace that with something like: ContentTask.spawn(gBrowser.selectedBrowser, null, function*() { content.console.log("foobarBazBug613280"); }); And in fact there's another usage of 'content' there (content.getSelection) that needs to be replaced with 'ContentTask' so that it will run correctly in multiprocess mode. See this doc for more information: https://wiki.mozilla.org/Electrolysis/e10s_test_tips#ContentTask
Flags: needinfo?(mconley)
Thanks for looking at this kevin! Let us know if you have further questions.
Mentor: mconley
I added the code from the suggestion and updated content.
Attachment #8787660 - Flags: review?(bgrinstead)
Comment on attachment 8787660 [details] [diff] [review] bug1273369_intermittent_webconsole_bug.diff Review of attachment 8787660 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/client/webconsole/test/browser_webconsole_bug_613280_jsterm_copy.js @@ +9,5 @@ > > function test() { > loadTab(TEST_URI).then(() => { > openConsole().then((HUD) => { > + ContentTask.spawn(gBrowser.selectedBrowser,null, function*(){ Nit: space between params @@ +11,5 @@ > loadTab(TEST_URI).then(() => { > openConsole().then((HUD) => { > + ContentTask.spawn(gBrowser.selectedBrowser,null, function*(){ > + content.console.log("foobarBazBug613280"); > + }); Nit: indent this line two space to match @@ +27,5 @@ > > function performTest(HUD, [result]) { > let msg = [...result.matched][0]; > let input = HUD.jsterm.inputNode; > + let selection = ContentTask; I've looked closer at this test, and I believe that these two lines `let selection =...` and `let contentSelection=..` can be removed, along with the entire `// Check if we first need to clear any existing selections.` block (https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/test/browser_webconsole_bug_613280_jsterm_copy.js#40-56). I don't see any reason why there would be an existing selection and it will make the test a lot simpler if it is removed.
Attachment #8787660 - Flags: review?(bgrinstead)
I think I made the changes you suggested. Is this good? I'm not quite sure what nit means
Attachment #8789546 - Flags: review?(bgrinstead)
(In reply to kevin from comment #23) > Created attachment 8789546 [details] [diff] [review] > bug1273369_intermittent_webconsole_bug.diff > > I think I made the changes you suggested. Is this good? I'm not quite sure > what nit means Hey kevin, thanks for the patch! "Nit" means (at least to my understanding) "this is a small thing" - essentially, bgrins was telling you that the particular issues starting with "Nit" aren't too serious.
Thank you for the information. It's been fun working on these patches thank you.
Comment on attachment 8789546 [details] [diff] [review] bug1273369_intermittent_webconsole_bug.diff Review of attachment 8789546 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Kevin, this looks great! I have sent this to our testing environment to make sure it's passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c49715e44eb0. If it looks good I'll land it once that finishes (usually takes a couple of hours to complete)
Attachment #8789546 - Flags: review?(bgrinstead) → review+
Assignee: nobody → kevchan85
Status: NEW → ASSIGNED
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/fx-team/rev/2b2dda648fde Remove CPOW usage in browser_webconsole_bug_613280_jsterm_copy.js;r=bgrins
https://hg.mozilla.org/mozilla-central/rev/2b2dda648fde
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Thanks Kevin! Looks like these failures have stopped after this landed
Attachment #8787660 - Attachment is obsolete: true
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: