Closed Bug 1273405 Opened 8 years ago Closed 8 years ago

Remove use of FlushableTaskQueue::Flush() from VorbisDataDecoder

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(4 files, 1 obsolete file)

Similar to bug 1273397.
Assignee: nobody → jwwang
Blocks: 1270039
Review commit: https://reviewboard.mozilla.org/r/53196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53196/
Attachment #8754626 - Flags: review?(jyavenard)
Attachment #8754627 - Flags: review?(jyavenard)
Attachment #8754628 - Flags: review?(jyavenard)
Attachment #8754629 - Flags: review?(jyavenard)
Attachment #8754630 - Flags: review?(jyavenard)
Comment on attachment 8754626 [details]
MozReview Request: Bug 1273405. Part 1 - move some functions to private. r=jya.

https://reviewboard.mozilla.org/r/53196/#review50818
Attachment #8754626 - Flags: review?(jyavenard) → review+
Comment on attachment 8754627 [details]
MozReview Request: Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.

https://reviewboard.mozilla.org/r/53198/#review50820
Attachment #8754627 - Flags: review?(jyavenard) → review+
Comment on attachment 8754626 [details]
MozReview Request: Bug 1273405. Part 1 - move some functions to private. r=jya.

https://reviewboard.mozilla.org/r/53196/#review50824

::: dom/media/platforms/agnostic/VorbisDecoder.h:34
(Diff revision 1)
> +  static const AudioConfig::Channel* VorbisLayout(uint32_t aChannels);
>  
> +private:
> +  ~VorbisDataDecoder();
>    RefPtr<InitPromise> Init() override;
>    nsresult Input(MediaRawData* aSample) override;

based on https://isocpp.org/wiki/faq/proper-inheritance#hiding-inherited-public

I'd say this is not a good thing to do and we should not put public virtual function as private in the derived class
Attachment #8754626 - Flags: review+
Comment on attachment 8754628 [details]
MozReview Request: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/53202/#review50826
Attachment #8754628 - Flags: review?(jyavenard) → review+
Attachment #8754629 - Flags: review?(jyavenard) → review+
Comment on attachment 8754629 [details]
MozReview Request: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.

https://reviewboard.mozilla.org/r/53204/#review50828
Attachment #8754630 - Flags: review?(jyavenard) → review+
Comment on attachment 8754630 [details]
MozReview Request: Bug 1273405. Part 4 - add assertions. r=jya.

https://reviewboard.mozilla.org/r/53206/#review50830
Comment on attachment 8754627 [details]
MozReview Request: Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53198/diff/1-2/
Attachment #8754627 - Attachment description: MozReview Request: Bug 1273405. Part 2 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya. → MozReview Request: Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.
Attachment #8754628 - Attachment description: MozReview Request: Bug 1273405. Part 3 - remove use of FlushableTaskQueue::Flush(). r=jya. → MozReview Request: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.
Attachment #8754629 - Attachment description: MozReview Request: Bug 1273405. Part 4 - remove use of FlushableTaskQueue. r=jya. → MozReview Request: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.
Attachment #8754630 - Attachment description: MozReview Request: Bug 1273405. Part 5 - add assertions. r=jya. → MozReview Request: Bug 1273405. Part 4 - add assertions. r=jya.
Comment on attachment 8754628 [details]
MozReview Request: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53202/diff/1-2/
Comment on attachment 8754629 [details]
MozReview Request: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53204/diff/1-2/
Comment on attachment 8754630 [details]
MozReview Request: Bug 1273405. Part 4 - add assertions. r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53206/diff/1-2/
Attachment #8754626 - Attachment is obsolete: true
(In reply to Jean-Yves Avenard [:jya] from comment #10)
> Comment on attachment 8754626 [details]
> MozReview Request: Bug 1273405. Part 1 - move some functions to private.
> r=jya.

> based on
> https://isocpp.org/wiki/faq/proper-inheritance#hiding-inherited-public
> 
> I'd say this is not a good thing to do and we should not put public virtual
> function as private in the derived class

This patch is removed.
You need to log in before you can comment on or make changes to this bug.