Remove use of FlushableTaskQueue::Flush() from VorbisDataDecoder

RESOLVED FIXED in Firefox 49

Status

()

Core
Audio/Video: Playback
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla49
Points:
---

Firefox Tracking Flags

(firefox49 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

2 years ago
Similar to bug 1273397.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Blocks: 1270039
Priority: -- → P2
(Assignee)

Comment 3

2 years ago
Created attachment 8754626 [details]
MozReview Request: Bug 1273405. Part 1 - move some functions to private. r=jya.

Review commit: https://reviewboard.mozilla.org/r/53196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53196/
Attachment #8754626 - Flags: review?(jyavenard)
Attachment #8754627 - Flags: review?(jyavenard)
Attachment #8754628 - Flags: review?(jyavenard)
Attachment #8754629 - Flags: review?(jyavenard)
Attachment #8754630 - Flags: review?(jyavenard)
(Assignee)

Comment 4

2 years ago
Created attachment 8754627 [details]
MozReview Request: Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.

Review commit: https://reviewboard.mozilla.org/r/53198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53198/
(Assignee)

Comment 5

2 years ago
Created attachment 8754628 [details]
MozReview Request: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

Review commit: https://reviewboard.mozilla.org/r/53202/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53202/
(Assignee)

Comment 6

2 years ago
Created attachment 8754629 [details]
MozReview Request: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.

Review commit: https://reviewboard.mozilla.org/r/53204/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53204/
(Assignee)

Comment 7

2 years ago
Created attachment 8754630 [details]
MozReview Request: Bug 1273405. Part 4 - add assertions. r=jya.

Review commit: https://reviewboard.mozilla.org/r/53206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53206/
Comment on attachment 8754626 [details]
MozReview Request: Bug 1273405. Part 1 - move some functions to private. r=jya.

https://reviewboard.mozilla.org/r/53196/#review50818
Attachment #8754626 - Flags: review?(jyavenard) → review+
Comment on attachment 8754627 [details]
MozReview Request: Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.

https://reviewboard.mozilla.org/r/53198/#review50820
Attachment #8754627 - Flags: review?(jyavenard) → review+
Comment on attachment 8754626 [details]
MozReview Request: Bug 1273405. Part 1 - move some functions to private. r=jya.

https://reviewboard.mozilla.org/r/53196/#review50824

::: dom/media/platforms/agnostic/VorbisDecoder.h:34
(Diff revision 1)
> +  static const AudioConfig::Channel* VorbisLayout(uint32_t aChannels);
>  
> +private:
> +  ~VorbisDataDecoder();
>    RefPtr<InitPromise> Init() override;
>    nsresult Input(MediaRawData* aSample) override;

based on https://isocpp.org/wiki/faq/proper-inheritance#hiding-inherited-public

I'd say this is not a good thing to do and we should not put public virtual function as private in the derived class
Attachment #8754626 - Flags: review+
Comment on attachment 8754628 [details]
MozReview Request: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

https://reviewboard.mozilla.org/r/53202/#review50826
Attachment #8754628 - Flags: review?(jyavenard) → review+
Attachment #8754629 - Flags: review?(jyavenard) → review+
Comment on attachment 8754629 [details]
MozReview Request: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.

https://reviewboard.mozilla.org/r/53204/#review50828
Attachment #8754630 - Flags: review?(jyavenard) → review+
(Assignee)

Comment 14

2 years ago
Comment on attachment 8754627 [details]
MozReview Request: Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53198/diff/1-2/
Attachment #8754627 - Attachment description: MozReview Request: Bug 1273405. Part 2 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya. → MozReview Request: Bug 1273405. Part 1 - rename some functions to be consistent with other MediaDataDecoder sub-classes. r=jya.
Attachment #8754628 - Attachment description: MozReview Request: Bug 1273405. Part 3 - remove use of FlushableTaskQueue::Flush(). r=jya. → MozReview Request: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.
Attachment #8754629 - Attachment description: MozReview Request: Bug 1273405. Part 4 - remove use of FlushableTaskQueue. r=jya. → MozReview Request: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.
Attachment #8754630 - Attachment description: MozReview Request: Bug 1273405. Part 5 - add assertions. r=jya. → MozReview Request: Bug 1273405. Part 4 - add assertions. r=jya.
(Assignee)

Comment 15

2 years ago
Comment on attachment 8754628 [details]
MozReview Request: Bug 1273405. Part 2 - remove use of FlushableTaskQueue::Flush(). r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53202/diff/1-2/
(Assignee)

Comment 16

2 years ago
Comment on attachment 8754629 [details]
MozReview Request: Bug 1273405. Part 3 - remove use of FlushableTaskQueue. r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53204/diff/1-2/
(Assignee)

Comment 17

2 years ago
Comment on attachment 8754630 [details]
MozReview Request: Bug 1273405. Part 4 - add assertions. r=jya.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53206/diff/1-2/
(Assignee)

Updated

2 years ago
Attachment #8754626 - Attachment is obsolete: true
(Assignee)

Comment 18

2 years ago
(In reply to Jean-Yves Avenard [:jya] from comment #10)
> Comment on attachment 8754626 [details]
> MozReview Request: Bug 1273405. Part 1 - move some functions to private.
> r=jya.

> based on
> https://isocpp.org/wiki/faq/proper-inheritance#hiding-inherited-public
> 
> I'd say this is not a good thing to do and we should not put public virtual
> function as private in the derived class

This patch is removed.

Comment 20

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/64e64f5a5035
https://hg.mozilla.org/mozilla-central/rev/7be21b2402d1
https://hg.mozilla.org/mozilla-central/rev/c123be765141
https://hg.mozilla.org/mozilla-central/rev/4174c9e21a40
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox49: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.