Closed Bug 1273510 Opened 6 years ago Closed 6 years ago

[TSF] Investigate what we need to do if ATOK stops using some Gecko specific hacks

Categories

(Core :: Widget: Win32, defect, P4)

All
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox49 --- wontfix
firefox51 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod, Whiteboard: tpi:+)

Attachments

(3 files)

ATOK 2011 - ATOK 2015 refers native caret position at deciding the position of candidate window position, navibar position, etc. However, this is too bad because even if we need to lie TSF and/or TIP for some reasons (e.g., new Web API for IME), it's impossible.

ATOK must refer our window class name before using the caret hack, so, we should change our window class name locally and investigate what we need to do for supporting ATOK which doesn't use the hack.

I think that we need to fix this bug by the end of Aug or Sep.
As far as investigated, ATOK 2016 works perfectly without any hacks for TS_E_NOLAYOUT!!!

ATOK 2011 has the problem, but ATOK 2012 works fine except NaviBar positioning. So, ATOK 2012 and ATOK 2013 must be added some hacks for TS_E_NOLAYOUT bug of TSF.

Probably, we can just disable native caret hack for current ATOK when ATOK 2017 or later is active.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Priority: -- → P4
Whiteboard: tpi:+
Comment on attachment 8781841 [details]
Bug 1273510 part.1 TSFTextStore should use native caret hack only when ATOK 2011 - 2016 is active

https://reviewboard.mozilla.org/r/72168/#review70508
Attachment #8781841 - Flags: review?(m_kato) → review+
Comment on attachment 8781842 [details]
Bug 1273510 part.2 Modify comment in IMMHandler::SetCandidateWindow()

https://reviewboard.mozilla.org/r/72170/#review70510
Attachment #8781842 - Flags: review?(m_kato) → review+
Comment on attachment 8781843 [details]
Bug 1273510 part.3 We should not return TS_E_NOLAYOUT when ATOK decides its suggest window

https://reviewboard.mozilla.org/r/72172/#review70512
Attachment #8781843 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/48fc8ff49e8f
part.1 TSFTextStore should use native caret hack only when ATOK 2011 - 2016 is active r=m_kato
https://hg.mozilla.org/integration/autoland/rev/19217cab82c6
part.2 Modify comment in IMMHandler::SetCandidateWindow() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/060472436aa5
part.3 We should not return TS_E_NOLAYOUT when ATOK decides its suggest window r=m_kato
You need to log in before you can comment on or make changes to this bug.