1273510 - [TSF] Investigate what we need to do if ATOK stops using some Gecko specific hacks

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect, P4)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

ATOK 2011 - ATOK 2015 refers native caret position at deciding the position of candidate window position, navibar position, etc. However, this is too bad because even if we need to lie TSF and/or TIP for some reasons (e.g., new Web API for IME), it's impossible.

ATOK must refer our window class name before using the caret hack, so, we should change our window class name locally and investigate what we need to do for supporting ATOK which doesn't use the hack.

I think that we need to fix this bug by the end of Aug or Sep.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

As far as investigated, ATOK 2016 works perfectly without any hacks for TS_E_NOLAYOUT!!!

ATOK 2011 has the problem, but ATOK 2012 works fine except NaviBar positioning. So, ATOK 2012 and ATOK 2013 must be added some hacks for TS_E_NOLAYOUT bug of TSF.

Probably, we can just disable native caret hack for current ATOK when ATOK 2017 or later is active.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f962ff135e8c

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ca309a8292f

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e52ea4738923

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0a4ecb5cb97

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=23e4b0ae1166

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9dab908cbbb0

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1273510 part.1 TSFTextStore should use native caret hack only when ATOK 2011 - 2016 is active

ATOK 2011 - 2016 check focused window class name if it's a Mozilla's window.  Then, they refer native caret position for deciding its popup window.  However, future ATOK release will stop referring native caret position on Mozilla's windows.  Therefore, we can stop creating native caret for new ATOK.

Review commit: https://reviewboard.mozilla.org/r/72168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72168/

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1273510 part.2 Modify comment in IMMHandler::SetCandidateWindow()

Review commit: https://reviewboard.mozilla.org/r/72170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72170/

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1273510 part.3 We should not return TS_E_NOLAYOUT when ATOK decides its suggest window

Returing TS_E_NOLAYOUT while ATOK shows suggest window causes moving suggest window to odd position.  This causes flicking the window.  Therefore, we shouldn't return TS_E_NOLAYOUT in this case.  In this case, ATOK queries whole rect of composition string.  So, we can return TS_E_NOLAYOUT for other cases.

Review commit: https://reviewboard.mozilla.org/r/72172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/72172/

Comment 11

[Makoto Kato [:m_kato]]

Comment on attachment 8781841 [details]
Bug 1273510 part.1 TSFTextStore should use native caret hack only when ATOK 2011 - 2016 is active

https://reviewboard.mozilla.org/r/72168/#review70508

Comment 12

[Makoto Kato [:m_kato]]

Comment on attachment 8781842 [details]
Bug 1273510 part.2 Modify comment in IMMHandler::SetCandidateWindow()

https://reviewboard.mozilla.org/r/72170/#review70510

Comment 13

[Makoto Kato [:m_kato]]

Comment on attachment 8781843 [details]
Bug 1273510 part.3 We should not return TS_E_NOLAYOUT when ATOK decides its suggest window

https://reviewboard.mozilla.org/r/72172/#review70512

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48fc8ff49e8f
part.1 TSFTextStore should use native caret hack only when ATOK 2011 - 2016 is active r=m_kato
https://hg.mozilla.org/integration/autoland/rev/19217cab82c6
part.2 Modify comment in IMMHandler::SetCandidateWindow() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/060472436aa5
part.3 We should not return TS_E_NOLAYOUT when ATOK decides its suggest window r=m_kato

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/48fc8ff49e8f
https://hg.mozilla.org/mozilla-central/rev/19217cab82c6
https://hg.mozilla.org/mozilla-central/rev/060472436aa5