Closed Bug 1273534 Opened 8 years ago Closed 8 years ago

Reps: NamedNodeMap rep is using wrong field in the grip

Categories

(DevTools :: Shared Components, defect)

Product:
DevTools
Component:
Shared Components
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: Honza, Assigned: gasolin)

References

Details

NamedNodeMap rep is using grip.preview.ownProperties to get items in the map. This field has been replace by 'item' and so, the rep should be fixed. We might want to keep backward compatibility (not sure when this changed). So, the following line: https://github.com/mozilla/gecko-dev/blob/fx-team/devtools/client/shared/components/reps/named-node-map.js#L67 Should do: let items = grip.preview ? grip.preview.items : []; Also, the label used in the NamedNodeMap() seems to be wrong. It's using weird "$prop.name" prefix. The test for this bug should be covered by bug 1264686 Honza
Component: Developer Tools: Framework → Developer Tools: Shared Components
since the blocked bug 1264686 is in devtools-html-2 list, this should be resolved at first
Blocks: devtools-html-2
Flags: qe-verify-
Whiteboard: [devtools-html] [triage]
Priority: -- → P3
Whiteboard: [devtools-html] [triage] → [reserve-html]
Whiteboard: [reserve-html] → [reserve-html][good taipei bug]
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
I am changing the dep here. As soon as bug 1264686 is fixed this one should be revisited (and maybe obsolete). So, bug 1264686 should be fixed first. Honza
No longer blocks: 1264686
Depends on: 1264686
thanks for clarify!
Status: ASSIGNED → NEW
invalid this bug since NamedNodeMap rep is removed in bug 126486
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
No longer blocks: devtools-html-2
Priority: P3 → --
Whiteboard: [reserve-html][good taipei bug]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.