Closed
Bug 1273534
Opened 8 years ago
Closed 8 years ago
Reps: NamedNodeMap rep is using wrong field in the grip
Categories
(DevTools :: Shared Components, defect)
DevTools
Shared Components
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: Honza, Assigned: gasolin)
References
Details
NamedNodeMap rep is using grip.preview.ownProperties to get items in the map. This field has been replace by 'item' and so, the rep should be fixed.
We might want to keep backward compatibility (not sure when this changed).
So, the following line:
https://github.com/mozilla/gecko-dev/blob/fx-team/devtools/client/shared/components/reps/named-node-map.js#L67
Should do:
let items = grip.preview ? grip.preview.items : [];
Also, the label used in the NamedNodeMap() seems to be wrong. It's using weird "$prop.name" prefix.
The test for this bug should be covered by bug 1264686
Honza
Component: Developer Tools: Framework → Developer Tools: Shared Components
Assignee | ||
Comment 1•8 years ago
|
||
since the blocked bug 1264686 is in devtools-html-2 list, this should be resolved at first
Blocks: devtools-html-2
Updated•8 years ago
|
Flags: qe-verify-
Whiteboard: [devtools-html] [triage]
Updated•8 years ago
|
Priority: -- → P3
Whiteboard: [devtools-html] [triage] → [reserve-html]
Reporter | ||
Updated•8 years ago
|
Whiteboard: [reserve-html] → [reserve-html][good taipei bug]
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Reporter | ||
Comment 2•8 years ago
|
||
I am changing the dep here. As soon as bug 1264686 is fixed this one should be revisited (and maybe obsolete).
So, bug 1264686 should be fixed first.
Honza
Assignee | ||
Comment 4•8 years ago
|
||
invalid this bug since NamedNodeMap rep is removed in bug 126486
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INVALID
Updated•8 years ago
|
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•