1273609 - Support manual_subframe transitionType in webNavigation events details

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

The webNavigation events should have their transitionType set to "manual_subframe" when their related sub-frame navigation has been generated by a user click.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: MozReview Request: Bug 1273609 - [webext] Support manual_subframe transitionType in webNavigation events details. r?krizsa

Review commit: https://reviewboard.mozilla.org/r/53306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53306/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8753471 [details]
MozReview Request: Bug 1273609 - [webext] Support manual_subframe transitionType in webNavigation events details. r?krizsa

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53306/diff/1-2/

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Luca Greco [:rpl] from comment #2)
> Comment on attachment 8753471 [details]
> MozReview Request: Bug 1273609 - [webext] Support manual_subframe
> transitionType in webNavigation events details. r?krizsa
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/53306/diff/1-2/

added missing test assets.

Comment 4

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8753471 [details]
MozReview Request: Bug 1273609 - [webext] Support manual_subframe transitionType in webNavigation events details. r?krizsa

https://reviewboard.mozilla.org/r/53306/#review50262

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Push to try of the attached patch:
- https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffbe6d429a2b3e07cee38c6e3419d05d443da7a1

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ae7edd9acb49

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ae7edd9acb49