1273771 - Add initial atom hooks for servo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Bobby Holley (:bholley)]

There's still stuff missing here, but getting this in-tree will allow us to get rid of our custom rust-selectors and simplify our build process a lot.

Comment 2

[Bobby Holley (:bholley)]

Attachment: Atom infrastructure for Servo. v1

This is based on earlier work by Ms2ger.

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8753693 [details] [diff] [review]
Atom infrastructure for Servo. v1

Review of attachment 8753693 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGkAtomList.h
@@ +2186,5 @@
> +GK_ATOM(sans_serif, "sans-serif")
> +GK_ATOM(cursive, "cursive")
> +GK_ATOM(fantasy, "fantasy")
> +GK_ATOM(monospace, "monospace")
> +

Were these meant to be in this patch?  I assume they're needed to make font-family work?

Comment 4

[Bobby Holley (:bholley)]

(In reply to Cameron McCormack (:heycam) from comment #3)
> Were these meant to be in this patch?  I assume they're needed to make
> font-family work?

Yeah I just bundled them in there.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48d8323378ac

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for Windows build bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/dcb2ccd92c84

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=48d8323378acd8d01fc09de523d3831b4857c39a

Comment 7

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=30cdeaec96db

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5695155fe1c7

Comment 9

[Cameron McCormack (:heycam)]

Attachment: followup nsDependentCString fix

Sorry, I missed this during review.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0208b789977

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5695155fe1c7
https://hg.mozilla.org/mozilla-central/rev/d0208b789977