1273815 - taskcluster win64 (opt) build failure: toolkit/mozapps/installer/packager.mk:216: recipe for target 'upload' failed

Status: RESOLVED FIXED

Description

[Rob Thijssen (:grenade UTC+2)]

build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=22b59f95028b60784592ba0bd4fc8dd11537b40e&selectedJob=20964868
raw-log: https://public-artifacts.taskcluster.net/bSW1avqMRx6Chju4ta9XJw/0/public/logs/command_000007.log

failure:

17:11:48     INFO -  mozmake.EXE[2]: Entering directory 'x:/Task_1463483835/build/src/obj-firefox/browser/installer'
17:11:48     INFO -  x:/Task_1463483835/build/src/obj-firefox/_virtualenv/Scripts/python.exe -u x:/Task_1463483835/build/src/build/upload.py --base-path ../../dist \
17:11:48     INFO -  	--package 'firefox-49.0a1.en-US.win64.zip' \
17:11:48     INFO -  	--properties-file ../../dist/mach_build_properties.json \
17:11:48     INFO -  	'../../dist/firefox-49.0a1.en-US.win64.zip' '../../dist/install/sea/firefox-49.0a1.en-US.win64.installer.exe'  '../../dist/win64/xpi/firefox-49.0a1.en-US.langpack.xpi'  '../../dist/mozharness.zip' '../../dist/firefox-49.0a1.en-US.win64.common.tests.zip' '../../dist/firefox-49.0a1.en-US.win64.cppunittest.tests.zip' '../../dist/firefox-49.0a1.en-US.win64.xpcshell.tests.zip' '../../dist/firefox-49.0a1.en-US.win64.mochitest.tests.zip' '../../dist/firefox-49.0a1.en-US.win64.talos.tests.zip' '../../dist/firefox-49.0a1.en-US.win64.reftest.tests.zip' '../../dist/firefox-49.0a1.en-US.win64.web-platform.tests.zip' '../../dist/firefox-49.0a1.en-US.win64.gtest.tests.zip' '../../dist/firefox-49.0a1.en-US.win64.crashreporter-symbols.zip'   '../../dist//firefox-49.0a1.en-US.win64.txt' '../../dist//firefox-49.0a1.en-US.win64.json' '../../dist//firefox-49.0a1.en-US.win64_info.txt' '../../dist//firefox-49.0a1.en-US.win64.mozinfo.json' '../../dist//firefox-49.0a1.en-US.win64.test_packages.json' '../../dist/jsshell-win64.zip'   ../../dist/host/bin/mar.exe  ../../dist/host/bin/mbsdiff.exe \
17:11:48     INFO -  	'../../dist//firefox-49.0a1.en-US.win64.checksums'
17:11:48     INFO -  One (and only one of UPLOAD_PATH or UPLOAD_TO_TEMP must be defined.
17:11:48     INFO -  x:/Task_1463483835/build/src/toolkit/mozapps/installer/packager.mk:216: recipe for target 'upload' failed
17:11:48     INFO -  mozmake.EXE[2]: *** [upload] Error 1
17:11:48     INFO -  mozmake.EXE[2]: Leaving directory 'x:/Task_1463483835/build/src/obj-firefox/browser/installer'
17:11:48     INFO -  x:/Task_1463483835/build/src/browser/build.mk:33: recipe for target 'upload' failed
17:11:48     INFO -  mozmake.EXE[1]: *** [upload] Error 2
17:11:48     INFO -  x:/Task_1463483835/build/src/build/moz-automation.mk:120: recipe for target 'automation/upload' failed
17:11:48     INFO -  mozmake.EXE: *** [automation/upload] Error 2
17:11:48     INFO -  mozmake.EXE: Leaving directory 'x:/Task_1463483835/build/src/obj-firefox'
17:11:48     INFO -  240 compiler warnings present.
17:11:53     INFO -  2
17:11:53    ERROR - Return code: 1
17:11:53  WARNING - setting return code to 2
17:11:53    FATAL - 'mach build' did not run successfully. Please check log for errors.

Comment 1

[Joel Maher ( :jmaher ) (UTC-4)]

I recall hitting this exact error with :pmoore, I believe he just adjusted some env vars, he would know best as to which files to tweak and which env variable to keep.

Comment 2

[Pete Moore [:pmoore][:pete]]

The problem is this setting: https://hg.mozilla.org/try/file/22b59f95028b60784592ba0bd4fc8dd11537b40e/testing/mozharness/configs/builds/releng_base_windows_32_builds.py#l93

The whole upload_env section can be removed.

Comment 3

[Pete Moore [:pmoore][:pete]]

Same for 64 bit builds (above link was for 32, but I see the log file was for 64 bit builds - but you'll want the same fix for both 32 and 64 bit builds anyway).

Comment 4

[Rob Thijssen (:grenade UTC+2)]

https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=21287334