Closed Bug 1273827 Opened 4 years ago Closed 4 years ago

Wait for reflow after showing HTMLTooltip in tests

Categories

(DevTools :: Framework, defect)

defect
Not set

Tracking

(firefox49 fixed, firefox-esr45- unaffected)

RESOLVED FIXED
Firefox 49
Tracking Status
firefox49 --- fixed
firefox-esr45 - unaffected

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

Dependency for Bug 881832 (See Bug 881832 comment 77).

In HTML tooltips tests we are showing the HTML tooltip and trigger a click on the tooltip content right after receiving the "shown" event.

With Bug 881832, the tooltip content might not have been painted yet, and the click cannot be fired.

We need to force the layout to reflow, either in the test or before firing the shown event.
Assignee: nobody → jdescottes
Blocks: 881832
Status: NEW → ASSIGNED
Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=da658c7c56b2

I prefer to handle this in the tests for now because I don't think the Tooltip should force a reflow by default every time it is shown.
Comment on attachment 8753750 [details]
MozReview Request: Bug 1273827 - Wait for reflow after showing HTMLTooltip in tests;r=ochameau

https://reviewboard.mozilla.org/r/53478/#review50234

I agree with you, that should be done directly into Tooltip API. Real code is going to have the same expectation as tests. i.e. be able to interact fully on shown event.
Please do followup on this!
Attachment #8753750 - Flags: review?(poirot.alex) → review+
https://hg.mozilla.org/mozilla-central/rev/8f36fe8daf67
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 49
Comment on attachment 8753750 [details]
MozReview Request: Bug 1273827 - Wait for reflow after showing HTMLTooltip in tests;r=ochameau

We need this to land along with some other work from bug 928187. 
This should land for 45.5.0esr. The release date for ESR has changed, and is now Nov. 15.
Attachment #8753750 - Flags: approval-mozilla-esr45+
The files this patch updates only exist on 49+. I assume that means nothing needs landing here for esr45?
Flags: needinfo?(jdescottes)
I don't think so, as you said this bug only fixes test files that were added in 49.

Daniel, are you sure this bug is related to bug 928187 ?
Flags: needinfo?(jdescottes) → needinfo?(dveditz)
I guess it's related to Bug 881832, clearing the ni? 
Not sure how the tracking flag should be updated here though, so I'll leave it as is for now.
Flags: needinfo?(dveditz)
Liz, since nothing needs to land for this bug for esr45, can we remove the tracking flag ?
Flags: needinfo?(lhenry)
Sure, thanks for following up. Sounds like nothing needs to land here.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.