1273835 - Set new cookie but the Expires is wrong by using "cookie list" on developer tool bar.

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Amy Chung [:Amy]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) 

Steps to reproduce:

Tested extensively in Firefox 47.0b6 on Mac OSX 10.10.5

1. Enter "www.example.com"
2. Used "cookie set test-1 test" on "Developer Toolbar".
3. Used "cookie list" to confirm cookie information, the expires showed "1/26/1970, 4:27:50 AM".
4. Double confirmed the cookie expires on storage, it showed "1/17/2038, 12:00:00 AM" on storage.

Comment 1

[Amy Chung [:Amy]]

Attachment: The cookie 'expires' value needs converting into something more readable. And The unit of expires is sec, the unit that in argument of Date() needs millisecond.

Hi Jason,
I have modified the translateExpires() function in devtools/shared/gcli/commands/cookie.js.
Because unit that in argument of Date() needs millisecond.

Comment 2

[Jason Duell]

Comment on attachment 8755211 [details] [diff] [review]
The cookie 'expires' value needs converting into something more readable.  And The unit of expires is sec, the unit that in argument of Date() needs millisecond.

Review of attachment 8755211 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!

Comment 3

[Amy Chung [:Amy]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd46e3955520

Comment 4

[Amy Chung [:Amy]]

Attachment: The cookie 'expires' value needs converting into something more readable. And The unit of expires is sec, the unit that in argument of Date() needs millisecond.

Comment 5

[Amy Chung [:Amy]]

Attachment: Modified the comment of translateExpires().

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/882e4cb1e069

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/882e4cb1e069