Closed Bug 1273835 Opened 4 years ago Closed 3 years ago

Set new cookie but the Expires is wrong by using "cookie list" on developer tool bar.

Categories

(Core :: Networking: Cookies, defect)

47 Branch
x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: amchung, Assigned: amchung)

Details

(Whiteboard: [necko-active])

Attachments

(1 file, 2 obsolete files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) 

Steps to reproduce:

Tested extensively in Firefox 47.0b6 on Mac OSX 10.10.5

1. Enter "www.example.com"
2. Used "cookie set test-1 test" on "Developer Toolbar".
3. Used "cookie list" to confirm cookie information, the expires showed "1/26/1970, 4:27:50 AM".
4. Double confirmed the cookie expires on storage, it showed "1/17/2038, 12:00:00 AM" on storage.
Whiteboard: [necko-active]
Assignee: nobody → amchung
Hi Jason,
I have modified the translateExpires() function in devtools/shared/gcli/commands/cookie.js.
Because unit that in argument of Date() needs millisecond.
Attachment #8755211 - Flags: review?(jduell.mcbugs)
Comment on attachment 8755211 [details] [diff] [review]
The cookie 'expires' value needs converting into something more readable.  And The unit of expires is sec, the unit that in argument of Date() needs millisecond.

Review of attachment 8755211 [details] [diff] [review]:
-----------------------------------------------------------------

Nice catch!
Attachment #8755211 - Flags: review?(jduell.mcbugs) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Attachment #8757266 - Attachment is obsolete: true
Attachment #8757268 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/882e4cb1e069
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.