1273908 - Simplify adding new kinds of GC thing

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jon Coppeard (:jonco)]

There are a bunch of places where the list of thing kinds is baked in.  These can be refactored using macros to construct them from a central source of information about GC things.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: simplify-adding-gc-thing

This turned out to be more far-reaching than I thought.  Mainly I put more information into FOR_EACH_ALLOCKIND (now split into two halves) and used this wherever possible.  I did the same for trace kinds too.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 8753944 [details] [diff] [review]
simplify-adding-gc-thing

Review of attachment 8753944 [details] [diff] [review]:
-----------------------------------------------------------------

Yup, that's exactly what I had in mind. Thanks for taking this!

::: js/public/TraceKind.h
@@ +97,5 @@
>  // are designed for use as array keys via EnumeratedArray.
>  enum class RootKind : int8_t
>  {
>      // These map 1:1 with trace kinds.
> +#define EXPAND_ROOT_KIND(name, type, _) \

|type| is unused here. The style I settled on by accident is _N for unused expansions: e.g. EXPAND_ROOT_KIND(name, _0, _1). I'd also be fine with always specifying all the names even if unused.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/106f482c6670

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/106f482c6670