1273943 - Emphasize search terms in awesomebar results using bold face

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Drew Willcoxon :adw]

http://cl.ly/3x3v1518181v

We want to land this in Nightly and uplift it to 48.

Comment 1

[Marco Bonardo [:mak]]

font-weight: 400; normal
font-weight: 500;
font-weight: 600;
font-weight: 700; bold

What are we supposed to use? I think stephen said "lighter bold", that maybe maps to 600?

Comment 2

[Stephen Horlander [:shorlander]]

I used 500. Which works on platforms that have that weight and seems to bump up to bold if they don't.

Comment 3

[Marco Bonardo [:mak]]

(In reply to Stephen Horlander [:shorlander] from comment #2)
> I used 500. Which works on platforms that have that weight and seems to bump
> up to bold if they don't.

mdn doesn't seem to agree

https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight

If a weight of exactly 500 is given, then 400 is used. If 400 is not available, then the heuristic for font weights greater than 500 is used.
This means that for fonts that provide only normal and bold, 100-500 are normal, and 600-900 are bold.

Comment 4

[Stephen Horlander [:shorlander]]

Oh, you are right. I did use 600 :)

Comment 5

[Drew Willcoxon :adw]

Attachment: MozReview Request: Bug 1273943 - Emphasize search terms in awesomebar results using bold face. r?mak

Review commit: https://reviewboard.mozilla.org/r/54314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54314/

Comment 6

[Marco Bonardo [:mak]]

Comment on attachment 8754974 [details]
MozReview Request: Bug 1273943 - Emphasize search terms in awesomebar results using bold face. r?mak

https://reviewboard.mozilla.org/r/54314/#review51194

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/10a29aed7ab0

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/10a29aed7ab0

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 8754974 [details]
MozReview Request: Bug 1273943 - Emphasize search terms in awesomebar results using bold face. r?mak

Approval Request Comment
[Feature/regressing bug #]: awesomebar redesign
[User impact if declined]: no polished ui
[Describe test coverage new/current, TreeHerder]: Nightly
[Risks and why]: very low risk, simple css changes
[String/UUID change made/needed]: none

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8754974 [details]
MozReview Request: Bug 1273943 - Emphasize search terms in awesomebar results using bold face. r?mak

Polish with small risk, taking it!

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/dd5adec22e6a

Comment 12

[Khalid Syfullah Zaman [:khalid32]]

I have reproduced this bug on Nightly 49.0a1 (2016-05-18) on Ubuntu 16.04 LTS, 64 bit!

The bug's fix is now verified on Latest Aurora 48.0a2!

Build ID: 20160601004014
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0

Also the bug’s fix is now verified on Latest Nightly 49.0a1!

Build ID: 20160531030258
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:49.0) Gecko/20100101 Firefox/49.0

Comment 14

[Mohammad Maruf Islam]

I have reproduced this bug with Firefox Nightly 49.0a1 (Build ID: 20160518030234) on 
Windows 8.1, 64-bit.

Verified as fixed with Latest Firefox Release 48.0 (Build ID: 20160726073904)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:48.0) Gecko/20100101 Firefox/48.0

Verified as fixed with Latest Firefox beta 49.0b5 (Build ID: 20160818050015)
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:49.0) Gecko/20100101 Firefox/49.0

As this bug is also verified on Ubuntu (comment 12), I am marking this as verified!