1273998 - B2GOS: SIGSEGV 0xb48a6438 in mozilla::ipc::FatalError (aProtocolName=0xb6101b06 "PPrintingParent", aMsg=0xb610179b "Clone() for PPrinting has not yet been implemented", aIsParent=aIsParent@entry=true)

Assignee

Description

•

8 years ago

current m-c (with patches to fix build) z3c kk

Program received signal SIGSEGV, Segmentation fault.
0xb48a6438 in mozilla::ipc::FatalError (aProtocolName=0xb6101b06 "PPrintingParent", aMsg=0xb610179b "Clone() for PPrinting has not yet been implemented", aIsParent=aIsParent@entry=true)
    at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/ProtocolUtils.cpp:455
455	    MOZ_CRASH("IPC FatalError in the parent process!");
(gdb) bt
#0  0xb48a6438 in mozilla::ipc::FatalError (aProtocolName=0xb6101b06 "PPrintingParent", aMsg=0xb610179b "Clone() for PPrinting has not yet been implemented", aIsParent=aIsParent@entry=true)
    at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/ProtocolUtils.cpp:455
#1  0xb492c642 in mozilla::embedding::PPrintingParent::FatalError (this=<optimized out>, aMsg=<optimized out>) at PPrintingParent.cpp:666
#2  0xb492c652 in mozilla::embedding::PPrintingParent::CloneProtocol (this=<optimized out>, aChannel=<optimized out>, aCtx=<optimized out>) at PPrintingParent.cpp:333
#3  0xb49b43f0 in mozilla::dom::PContentParent::CloneManagees (this=this@entry=0xaccac800, aSource=aSource@entry=0xab7a0800, aCtx=aCtx@entry=0xbe9e53bc) at PContentParent.cpp:3496
#4  0xb533a6c0 in mozilla::dom::ContentParent::ContentParent(mozilla::dom::ContentParent*, nsAString_internal const&, int, nsTArray<mozilla::ipc::ProtocolFdMapping>&&) (this=this@entry=0xaccac800, aTemplate=aTemplate@entry=0xab7a0800, 
    aAppManifestURL=..., aPid=aPid@entry=1816, aFds=aFds@entry=<unknown type in /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/objdir-gecko/toolkit/library/libxul.so, CU 0x1079fb71, DIE 0x1090c8ff>)
    at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/ContentParent.cpp:2463
#5  0xb533b056 in mozilla::dom::ContentParent::OnNewProcessCreated(unsigned int, mozilla::UniquePtr<nsTArray<mozilla::ipc::ProtocolFdMapping>, mozilla::DefaultDelete<nsTArray<mozilla::ipc::ProtocolFdMapping> > >&&) (this=0xab7a0800, aPid=1816, 
    aFds=<optimized out>) at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/ContentParent.cpp:3050
#6  0xb532fe16 in applyImpl<mozilla::dom::ContentParent, void (mozilla::dom::ContentParent::*)(unsigned int, mozilla::UniquePtr<nsTArray<mozilla::ipc::ProtocolFdMapping> >&&), StoreCopyPassByValue<unsigned int>, StoreCopyPassByRRef<mozilla::UniquePtr<nsTArray<mozilla::ipc::ProtocolFdMapping>, mozilla::DefaultDelete<nsTArray<mozilla::ipc::ProtocolFdMapping> > > >, 0u, 1u> (args=..., m=<optimized out>, o=<optimized out>) at ../../dist/include/nsThreadUtils.h:707
#7  apply<mozilla::dom::ContentParent, void (mozilla::dom::ContentParent::*)(unsigned int, mozilla::UniquePtr<nsTArray<mozilla::ipc::ProtocolFdMapping> >&&)> (m=<optimized out>, o=<optimized out>, this=<optimized out>)
    at ../../dist/include/nsThreadUtils.h:714
#8  nsRunnableMethodImpl<void (mozilla::dom::ContentParent::*)(unsigned int, mozilla::UniquePtr<nsTArray<mozilla::ipc::ProtocolFdMapping>, mozilla::DefaultDelete<nsTArray<mozilla::ipc::ProtocolFdMapping> > >&&), false, false, unsigned int, mozilla::UniquePtr<nsTArray<mozilla::ipc::ProtocolFdMapping>, mozilla::DefaultDelete<nsTArray<mozilla::ipc::ProtocolFdMapping> > >&&>::Run() (this=<optimized out>) at ../../dist/include/nsThreadUtils.h:741
#9  0xb46a8da0 in nsThread::ProcessNextEvent (this=0xb6a02470, aMayWait=<optimized out>, aResult=0xbe9e54e7) at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/xpcom/threads/nsThread.cpp:1073
#10 0xb46ba1e0 in NS_ProcessNextEvent (aThread=<optimized out>, aThread@entry=0xb6a02470, aMayWait=aMayWait@entry=false) at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/xpcom/glue/nsThreadUtils.cpp:290
#11 0xb48a4438 in mozilla::ipc::MessagePump::Run (this=0xb6a55490, aDelegate=0xb27c51a0) at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/MessagePump.cpp:98
#12 0xb4893da2 in RunHandler (this=0xb27c51a0) at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/chromium/src/base/message_loop.cc:228
#13 MessageLoop::Run (this=0xb27c51a0) at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/chromium/src/base/message_loop.cc:208
#14 0xb5416fd6 in nsBaseAppShell::Run (this=0xb6a79ac0) at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/widget/nsBaseAppShell.cpp:156
#15 0xb57cd27e in nsAppStartup::Run (this=0xb023f160) at /home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/toolkit/components/startup/nsAppStartup.cpp:284
#16 0xb57f1e4e in XREMain::XRE_mainRun (this=this@entry=0xbe9e5668) at ../../../gecko/toolkit/xre/nsAppRunner.cpp:4369
#17 0xb57f20ec in XREMain::XRE_main (this=this@entry=0xbe9e5668, argc=argc@entry=1, argv=argv@entry=0xb6a2b0c8, aAppData=aAppData@entry=0xb6fbfd60 <_ZL8sAppData>) at ../../../gecko/toolkit/xre/nsAppRunner.cpp:4473
#18 0xb57f22e2 in XRE_main (argc=1, argv=0xb6a2b0c8, aAppData=0xb6fbfd60 <_ZL8sAppData>, aFlags=<optimized out>) at ../../../gecko/toolkit/xre/nsAppRunner.cpp:4581
#19 0xb6fa1ae6 in do_main (argc=argc@entry=1, argv=argv@entry=0xb6a2b0c8) at ../../../gecko/b2g/app/nsBrowserApp.cpp:166
#20 0xb6fa1c08 in b2g_main (argc=1, argv=<optimized out>) at ../../../gecko/b2g/app/nsBrowserApp.cpp:298
#21 0xb6fa1980 in RunProcesses (aReservedFds=..., argv=0xbe9e6954, argc=1) at ../../../gecko/b2g/app/B2GLoader.cpp:233
#22 main (argc=1, argv=0xbe9e6954) at ../../../gecko/b2g/app/B2GLoader.cpp:300

:gerard-majax

Assignee

Comment 1

•

8 years ago

fallout from bug 1189846 ?

Blocks: 1189846

:gerard-majax

Assignee

Comment 2

•

8 years ago

NS_PRINTING=1 in config.status, I don't think we want printing on B2GOS ?

:gerard-majax

Assignee

Comment 3

•

8 years ago

It looks like --disable-printing is broken :/

 in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl:18: error: can't locate include file `PRemotePrintJob.ipdl'
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:6: error: can't locate include file `PRemotePrintJob.ipdl'
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh', line 10:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintSettingsDialog.ipdl:8: error: can't locate include file `PRemotePrintJob.ipdl'
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh', line 10:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintSettingsDialog.ipdl:11: error: can't locate include file `PRemotePrintJob.ipdl'
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:23: error: can't define a protocol in a header.  Do it in a protocol spec instead.
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:71: error: can't define a protocol in a header.  Do it in a protocol spec instead.
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:70: error: can't define a protocol in a header.  Do it in a protocol spec instead.
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:16: error: can't define a protocol in a header.  Do it in a protocol spec instead.
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:23: error: can't define a protocol in a header.  Do it in a protocol spec instead.
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:45: error: can't define a protocol in a header.  Do it in a protocol spec instead.
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:44: error: can't define a protocol in a header.  Do it in a protocol spec instead.
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:44: error: can't define a protocol in a header.  Do it in a protocol spec instead.
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:11: error: can't define a protocol in a header.  Do it in a protocol spec instead.
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/accessible/ipc/PDocAccessible.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PFileDescriptorSet.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/ipc/glue/PBackground.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBFactory.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabase.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/indexedDB/PBackgroundIDBDatabaseRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundMutableFile.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileHandle.ipdl', line 5:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/filehandle/PBackgroundFileRequest.ipdl', line 6:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBlob.ipdl', line 7:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PContent.ipdl', line 11:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/dom/ipc/PBrowser.ipdl', line 42:
  in file included from `/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrinting.ipdl', line 6:
/home/alex/codaz/Mozilla/b2g/devices/XperiaZ3c/B2G/gecko/embedding/components/printingui/ipc/PPrintingTypes.ipdlh:46: error: can't define a protocol in a header.  Do it in a protocol spec instead.
Specification could not be parsed.

Flags: needinfo?(bobowen.code)

:gerard-majax

Assignee

Comment 4

•

8 years ago

So, layout/printing/moz.build which adds definition of IPDL file ipc/PRemotePrintJob.ipdl is being guarded by CONFIG['NS_PRINTING'] in layout/moz.build, while embedding/components/printingui/ipc/moz.build gets pulled whatever is the value of NS_PRINTING. And we have dom/ipc/PBrowser.ipdl that has references against this IPDL.

:gerard-majax

Assignee

Comment 5

•

8 years ago

Attached patch Proper export of printing IPDL with --disable-printing r? (obsolete) — Details — Splinter Review

This is unblocking build for me, build and testing in progress ...

:gerard-majax

Assignee

Comment 6

•

8 years ago

Attached patch Proper export of printing IPDL with --disable-printing r? (obsolete) — Details — Splinter Review

Attachment #8754008 - Attachment is obsolete: true

:gerard-majax

Assignee

Updated

•

8 years ago

Blocks: 1252143

:gerard-majax

Assignee

Updated

•

8 years ago

Assignee: nobody → lissyx+mozillians

:gerard-majax

Assignee

Updated

•

8 years ago

Attachment #8754011 - Attachment is obsolete: true

:gerard-majax

Assignee

Comment 7

•

8 years ago

Attached file MozReview Request: Bug 1273998 - Proper export of printing IPDL with --disable-printing r?bobowen,?glandium — Details

Review commit: https://reviewboard.mozilla.org/r/53656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/53656/

Attachment #8754027 - Flags: review?(bobowen.code)

:gerard-majax

Assignee

Comment 8

•

8 years ago

Attached file Gonk-misc PR — Details

Attachment #8754028 - Flags: review?(fabrice)

[:fabrice] Fabrice Desré

Updated

•

8 years ago

Attachment #8754028 - Flags: review?(fabrice) → review+

Bob Owen (:bobowen)

Comment 9

•

8 years ago

Comment on attachment 8754027 [details]
MozReview Request: Bug 1273998 - Proper export of printing IPDL with --disable-printing r?bobowen,?glandium

https://reviewboard.mozilla.org/r/53656/#review50578

I think this looks OK apart from that question, but this changes quite a few build files, so I don't think I should be the only reviewer.
I spoke to glandium on IRC and he said he'll take a look, so could you add him please.

Looks like I've broken this more than once ... sorry about that.
Although maybe it was already broken even before that.

::: layout/printing/moz.build:7
(Diff revision 1)
> +XPIDL_MODULE = 'layout_printing'
> +
>  XPIDL_SOURCES += [
>      'nsIPrintProgress.idl',
>      'nsIPrintProgressParams.idl',
>      'nsIPrintStatusFeedback.idl',
>  ]

Why are these not protected by NS_PRINTING as well?

If they can be, would it have been easier to just add print/ipc/PRemotePrintJob.ipdl to the parent directory moz.build?

Attachment #8754027 - Flags: review?(bobowen.code)

:gerard-majax

Assignee

Comment 10

•

8 years ago

I was not sure moving the file was a good thing :)

Bob Owen (:bobowen)

Comment 11

•

8 years ago

(In reply to Alexandre LISSY :gerard-majax from comment #10)
> I was not sure moving the file was a good thing :)

Just to be clear, I meant just moving the addition to IPDL_SOURCES, not the actual file.

Flags: needinfo?(bobowen.code)

:gerard-majax

Assignee

Comment 12

•

8 years ago

Comment on attachment 8754027 [details]
MozReview Request: Bug 1273998 - Proper export of printing IPDL with --disable-printing r?bobowen,?glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53656/diff/1-2/

Attachment #8754027 - Flags: review?(bobowen.code)

Bob Owen (:bobowen)

Comment 13

•

8 years ago

Comment on attachment 8754027 [details]
MozReview Request: Bug 1273998 - Proper export of printing IPDL with --disable-printing r?bobowen,?glandium

https://reviewboard.mozilla.org/r/53656/#review50624

Thanks, I still think glandium should take a look, given this is all build config.

It looks like we might be able to move more things behind NS_PRINTING, but that should proably be a follow-up.

Attachment #8754027 - Flags: review?(bobowen.code) → review+

:gerard-majax

Assignee

Comment 14

•

8 years ago

Comment on attachment 8754027 [details]
MozReview Request: Bug 1273998 - Proper export of printing IPDL with --disable-printing r?bobowen,?glandium

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/53656/diff/2-3/

Attachment #8754027 - Attachment description: MozReview Request: Bug 1273998 - Proper export of printing IPDL with --disable-printing r?bobowen → MozReview Request: Bug 1273998 - Proper export of printing IPDL with --disable-printing r?bobowen,?glandium

:gerard-majax

Assignee

Updated

•

8 years ago

Attachment #8754027 - Flags: review?(mh+mozilla)

Mike Hommey [:glandium]

Updated

•

8 years ago

Attachment #8754027 - Flags: review?(mh+mozilla) → review+

Mike Hommey [:glandium]

Comment 15

•

8 years ago

Comment on attachment 8754027 [details]
MozReview Request: Bug 1273998 - Proper export of printing IPDL with --disable-printing r?bobowen,?glandium

https://reviewboard.mozilla.org/r/53656/#review50894

It'd be worth check why we don't do preprocessing on ipdl, and whether we should.

:gerard-majax

Assignee

Updated

•

8 years ago

Depends on: 1274518

:gerard-majax

Assignee

Comment 16

•

8 years ago

(In reply to Mike Hommey [:glandium] from comment #15)
> Comment on attachment 8754027 [details]
> MozReview Request: Bug 1273998 - Proper export of printing IPDL with
> --disable-printing r?bobowen,?glandium
> 
> https://reviewboard.mozilla.org/r/53656/#review50894
> 
> It'd be worth check why we don't do preprocessing on ipdl, and whether we
> should.

Sure, filed as bug 1274518 to get proper status on this question :)

:gerard-majax

Assignee

Comment 17

•

8 years ago

https://github.com/mozilla-b2g/gonk-misc/commit/6d240f935df2d84e38c8e7fa4aeac6b0c383b30f

:gerard-majax

Assignee

Updated

•

8 years ago

Blocks: 1274650

Pulsebot

Comment 18

•

8 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/63cfc2bd51fa

:gerard-majax

Assignee

Comment 19

•

8 years ago

https://hg.mozilla.org/projects/pine/rev/5fd1cdc69d66

Whiteboard: fixed-in-pine

Carsten Book [:Tomcat]

Comment 20

•

8 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/63cfc2bd51fa

Status: NEW → RESOLVED

Closed: 8 years ago

status-firefox49: --- → fixed

Resolution: --- → FIXED

Proper export of printing IPDL with --disable-printing r? 8 years ago :gerard-majax 2.17 KB, patch		Details \| Diff \| Splinter Review
Proper export of printing IPDL with --disable-printing r? 8 years ago :gerard-majax 4.11 KB, patch		Details \| Diff \| Splinter Review
MozReview Request: Bug 1273998 - Proper export of printing IPDL with --disable-printing r?bobowen,?glandium 8 years ago :gerard-majax 58 bytes, text/x-review-board-request	bobowen : review+ glandium : review+	Details
Gonk-misc PR 8 years ago :gerard-majax 49 bytes, text/x-github-pull-request	fabrice : review+	Details \| Review